Warn instead of throwing an error

And after the warning, return. This prevents Node-RED from crashing.
victronenergy · Nov 8, 2024 · 855224d · 855224d
1 parent 1ce472e
commit 855224d
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/src/nodes/victron-virtual.html b/src/nodes/victron-virtual.html
@@ -39,6 +39,7 @@
     RED.nodes.registerType('victron-virtual',{
         category: 'Victron Energy',
         color: '#f7ab3e',
+        paletteLabel: "Virtual Device",
         defaults: {
             name: {value:""},
             device: {value:"", required: true},

diff --git a/src/nodes/victron-virtual.js b/src/nodes/victron-virtual.js
@@ -178,11 +178,27 @@ module.exports = function (RED) {
         : dbus.systemBus()
     }
     if (!this.bus) {
-      throw new Error('Could not connect to the DBus session bus.')
+      node.warn(
+        'Could not connect to the DBus session bus.'
+      )
+      node.status({
+        color: 'red',
+        shape: 'dot',
+        text: 'Could not connect to the DBus session bus.'
+      })
+      return
     }
 
     if (!config.device || config.device === '') {
-      throw new Error('Node needs a configuration first')
+      node.warn(
+        'No device configured'
+      )
+      node.status({
+        color: 'red',
+        shape: 'dot',
+        text: 'No device configured'
+      })
+      return
     }
 
     let serviceName = `com.victronenergy.${config.device}.virtual_${this.id}`