A second loadSource call autoplays primary content immediately.

[matvp91]

What version of Hls.js are you using?

v1.6.0-beta

What browser (including version) are you using?

Chrome

What OS (including version) are you using?

macOS

Test stream

No response

Configuration

{}

Additional player setup steps

This is a regression compared to v1.5.

A sample with v1.5: https://stackblitz.com/edit/vitejs-vite-fkf2xf
A sample with v1.6-beta: https://stackblitz.com/edit/vitejs-vite-tohum2

The same steps to reproduce result in different behavior, with v1.5 not starting the asset (as it requires a user gesture), but v1.6 does.

Checklist

• The issue observed is not already reported by searching on Github under https://github.com/video-dev/hls.js/issues
• The issue occurs in the stable client (latest release) on https://hlsjs.video-dev.org/demo and not just on my page
• The issue occurs in the latest client (main branch) on https://hlsjs-dev.video-dev.org/demo and not just on my page
• The stream has correct Access-Control-Allow-Origin headers (CORS)
• There are no network errors such as 404s in the browser console when trying to play the stream

Steps to reproduce

1. Click "loadSource".
2. Click "play".
3. Click "loadSource" again, and you'll notice that playback starts immediately.

Expected behaviour

A subsequent loadSource call should not start playback when no autoplay attribute is present.

What actually happened?

A subsequent loadSource call starts playback immediately, with autoplay not present on the video element.

Console output

N/A

Chrome media internals output

No response

[robwalch]

Adding Interstitials label even though this is reproducible without Interstitials in the HLS asset. The running theory is that the play() calls in the Interstitial controller are responsible:

      this.resumePrimary(scheduledItem, index);
      if (this.shouldPlay) {
        this.hls.media?.play();
      }

Setting this.shouldPlay = false; on onManifestLoading may fix this.

[robwalch]

Just merged #6879 into dev: https://hlsjs-dev.video-dev.org/demo/

Two changes relative to this issue:

1. The interstitial-controller only emits INTERSTITIALS_PRIMARY_RESUMED when returning from an Interstitial (no longer emitted on start)
2. hls.startLoad() will not be called on the primary player if loading is stopped (or hasn't autostarted)