Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live reload throttling per level details schedule #6879

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Nov 30, 2024

This PR will...

  • Improve live reload scheduling (and fix a regression in dev)
  • Improve blocking requests with parts and low-latency mode disabled
  • Defer autostart until after manifest loasded and level loaded when media playlist is source
  • Added hls.loadingEnabled getter
  • Prevent Interstitial controller from calling startLoad when stopped and do not resume primary on first item

Why is this Pull Request needed?

Prevents redundant playlist request on startup and fixes autostart behavior in development.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

- Improve blocking requests with parts and low-latency mode disabled
- Defer autostart until after manifest loasded and level loaded when media playlist is source
Fixes #6858

Interstitial startup fixes
- Added `hls.loadingEnabled` getter
- Do not call startLoad when stopped and do not resume primary on first item
Fixes #6839
@robwalch robwalch added this to the 1.6.0 milestone Nov 30, 2024
@robwalch robwalch marked this pull request as draft December 2, 2024 17:07
@robwalch robwalch marked this pull request as ready for review December 2, 2024 17:31
@robwalch robwalch force-pushed the bugfix/live-reload-autostart branch from a42e7e1 to 0b87436 Compare December 2, 2024 22:57
@robwalch robwalch merged commit b3be549 into master Dec 3, 2024
16 checks passed
@robwalch robwalch deleted the bugfix/live-reload-autostart branch December 3, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant