fix(vgControls): Track playing state of media specified in vgFor #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgControls can set vgFor to track play/pause/ads for play and pause checking of control hiding, but by checking this.API in the hideAsync function a project without vgMaster set can end up checking the state of a different media than the one bound to vgControls, which could be sitting in a pause state while the media bound to the controls is happily in a playing state. This change sets this.target to always have a media binding so that the controls are either controlling the one found in vgFor or the default media of the API (meaning this adds specificity without changing the previous result of getting state values from the default media object). videogular#716
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vgControls can set vgFor to track play/pause/ads for play and pause checking of control hiding, but
by checking this.API in the hideAsync function a project without vgMaster set can end up checking
the state of a different media than the one bound to vgControls, which could be sitting in a pause
state while the media bound to the controls is happily in a playing state. This change sets
this.target to always have a media binding so that the controls are either controlling the one found
in vgFor or the default media of the API (meaning this adds specificity without changing the
previous result of getting state values from the default media object).
Tests have been updated to include a vgMedia object for the new binding.
#716