Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vgControls): Track playing state of media specified in vgFor #743

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(vgControls): Track playing state of media specified in vgFor #743

wants to merge 1 commit into from

Commits on Jun 13, 2018

  1. fix(vgControls): Track playing state of media specified in vgFor 

    vgControls can set vgFor to track play/pause/ads for play and pause checking of control hiding, but
by checking this.API in the hideAsync function a project without vgMaster set can end up checking
the state of a different media than the one bound to vgControls, which could be sitting in a pause
state while the media bound to the controls is happily in a playing state.  This change sets
this.target to always have a media binding so that the controls are either controlling the one found
in vgFor or the default media of the API (meaning this adds specificity without changing the
previous result of getting state values from the default media object).

videogular#716
    @kwarismian
    kwarismian committed Jun 13, 2018
    Configuration menu
    Copy the full SHA
    bf6191f View commit details
    Browse the repository at this point in the history