Ch/design tweak test #459
Ch/design tweak test #459
Conversation
| </aside> | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
What if you tracked the current section as component state? It could default to 0. Instead of manually assigning the class, you could make line 45 read like:
className={section === this.state.current ? '-active' : ''}Then you avoid needing to select the elements on initial render too.
There was a problem hiding this comment.
good call, I was able to use a state prop that already existed 👍🏼
| @@ -57,9 +58,10 @@ export default class IndexPage extends React.Component { | |||
| onIntersection = observed => { | |||
| let entry = observed[0] | |||
| let section = parseInt(entry.target.dataset.section) | |||
| let isIntersecting = entry.intersectionRatio >= 1.0 | |||
There was a problem hiding this comment.
Is the 1.0 here the same threshold as observeOptions.threshold?
Codecov Report
@@ Coverage Diff @@
## master #459 +/- ##
===========================================
- Coverage 93.19% 73.68% -19.52%
===========================================
Files 29 44 +15
Lines 1029 1368 +339
Branches 197 255 +58
===========================================
+ Hits 959 1008 +49
- Misses 59 295 +236
- Partials 11 65 +54
Continue to review full report at Codecov.
|
…ange color as well
ccchwang
force-pushed
the
ch/design-tweak-test
branch
from
f5c06dc to
94e8983
Compare
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
If yes, please describe the impact and migration path for existing applications:
Does this PR fulfill these requirements:
yarn prettyhas been runAdditional Information