Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ch/design tweak #460

Closed
wants to merge 12 commits into from
Closed

Ch/design tweak #460

wants to merge 12 commits into from

Conversation

ccchwang
Copy link

@ccchwang ccchwang commented Jan 4, 2018

Created new branch because merging/rebasing got messed up on original branch #459 (ch/design-tweak-test).

@codecov-io
Copy link

codecov-io commented Jan 4, 2018

Codecov Report

Merging #460 into master will increase coverage by 1.9%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #460     +/-   ##
=========================================
+ Coverage   93.19%   95.09%   +1.9%     
=========================================
  Files          29       30      +1     
  Lines        1029     1061     +32     
  Branches      197      201      +4     
=========================================
+ Hits          959     1009     +50     
+ Misses         59       44     -15     
+ Partials       11        8      -3
Impacted Files Coverage Δ
packages/microcosm/src/install-devtools.js 16.66% <0%> (-50%) ⬇️
packages/microcosm/src/lifecycle.js 83.33% <0%> (-16.67%) ⬇️
packages/microcosm/src/utils.js 97.26% <0%> (-1.37%) ⬇️
packages/microcosm/src/addons/action-button.js 96.87% <0%> (ø)
packages/microcosm/src/history.js 86.36% <0%> (+1.51%) ⬆️
packages/microcosm/src/action.js 98.29% <0%> (+1.7%) ⬆️
packages/microcosm/src/coroutine.js 48% <0%> (+4%) ⬆️
packages/microcosm/src/microcosm.js 98.11% <0%> (+5.66%) ⬆️
packages/microcosm/src/effect-engine.js 100% <0%> (+11.11%) ⬆️
packages/microcosm/src/domain-engine.js 95.58% <0%> (+13.23%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25a2764...65623dd. Read the comment docs.

@ccchwang ccchwang closed this Jan 4, 2018
@ccchwang ccchwang deleted the ch/design-tweak branch January 4, 2018 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants