Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TLiteralInt::$value typed #9516

Closed
weirdan opened this issue Mar 15, 2023 · 2 comments · Fixed by #9517
Closed

Make TLiteralInt::$value typed #9516

weirdan opened this issue Mar 15, 2023 · 2 comments · Fixed by #9517
Labels
enhancement

Comments

@weirdan
Copy link
Collaborator

weirdan commented Mar 15, 2023

Refs #9499 (comment)

This should be a safe and backwards-compatible change because:

  1. The class is final.
  2. The class is immutable.
@psalm-github-bot

This comment was marked as off-topic.

Sign in to view
@weirdan
Copy link
Collaborator Author

weirdan commented Mar 15, 2023

And while we're at it, we could make TLiteralFloat::$value typed as well.

@weirdan weirdan mentioned this issue Mar 15, 2023
Merged
weirdan added a commit to weirdan/psalm that referenced this issue Mar 15, 2023
@weirdan
Make TLiteralFloat::$value and TLiteralInt::$value typed
c6978a2 
Fixes vimeo#9516
weirdan added a commit to weirdan/psalm that referenced this issue Aug 20, 2023
@weirdan
Make TLiteralFloat::$value and TLiteralInt::$value typed
9aade96 
Fixes vimeo#9516
@weirdan weirdan closed this as completed Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make TLiteralFloat::$value and TLiteralInt::$value typed weirdan/psalm
1 participant
@weirdan