Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TLiteralFloat::$value and TLiteralInt::$value typed #9517

Merged
merged 2 commits into from
Aug 20, 2023
Merged

Make TLiteralFloat::$value and TLiteralInt::$value typed #9517

merged 2 commits into from
Aug 20, 2023

Conversation

weirdan
Copy link
Collaborator

@weirdan weirdan commented Mar 15, 2023

Fixes #9516

@weirdan weirdan added the release:internal The PR will be included in 'Internal changes' section of the release notes label Mar 15, 2023
@weirdan
Copy link
Collaborator Author

weirdan commented Mar 15, 2023

BCC failure discussed here: Roave/BackwardCompatibilityCheck#742

@weirdan weirdan force-pushed the typed-values-for-literal-numeric-types branch from c6978a2 to 9aade96 Compare August 20, 2023 05:39
@weirdan weirdan merged commit efe455f into vimeo:master Aug 20, 2023
38 of 39 checks passed
@weirdan weirdan deleted the typed-values-for-literal-numeric-types branch August 20, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release:internal The PR will be included in 'Internal changes' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make TLiteralInt::$value typed
1 participant
@weirdan