Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix display of FBX models with only one color for vertices #545

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Fix display of FBX models with only one color for vertices #545

merged 1 commit into from
Jul 23, 2020

Conversation

ctrlaltdavid
Copy link
Collaborator

Fixes issue: #294

@ctrlaltdavid ctrlaltdavid linked an issue Jul 17, 2020 that may be closed by this pull request
Renderer ignores vertex colors if only one value is given. #294
Closed
@ctrlaltdavid
Copy link
Collaborator Author

Testing

  1. FBX and glTF models with a single colour for all vertices should display that colour.

The following test models from Aitold both comprise two cubes: one with all vertices green and the other with green vertices except for one blue.
The cube with all vertices green erroneously displays as white in 2020.2.3 but should display as green in this PR's build.

http://ctrlaltstudio.com/downloads/vircadia-dev/vertexcolors.fbx
http://ctrlaltstudio.com/downloads/vircadia-dev/vertexcolors.glb
  1. FBX and glTF models with no colours should display as white.

As a check that the code change hasn't messed up display of models with no colours, the following models are each a cube with no vertex colours.
All should display as white cubes.

http://ctrlaltstudio.com/downloads/vircadia-dev/NoVertexColors.fbx
http://ctrlaltstudio.com/downloads/vircadia-dev/NoVertexColors.glb
http://ctrlaltstudio.com/downloads/vircadia-dev/NoVertexColorsCheckboxNoMaterials.glb
  1. Content in different should display as normal.

@two-one-five two-one-five added this to the 2020.2.4 Release milestone Jul 17, 2020
@vircadia-build-notifier
Copy link

The following links are available:
build (macOS-latest, full)

build (ubuntu-18.04, full)

build (windows-latest, full)

@HifiExperiments HifiExperiments added CR Approved At least one code reviewer has approved the PR. and removed needs CR (code review) labels Jul 17, 2020
@SilverfishVR
Copy link
Contributor

Looks good, I went to several domains looking for weirdness, didn't find any but I'm sure there are models with a unintentional vertexcolor applied that now looks different, easily fixable if it comes up. 👍

Screenshot 2020-07-17 22 48 13

@two-one-five two-one-five added QA Approved The PR has been tested successfully. and removed needs testing (QA) The PR is ready for testing labels Jul 23, 2020
@two-one-five two-one-five merged commit 65d1a88 into vircadia:master Jul 23, 2020
@ctrlaltdavid ctrlaltdavid deleted the fix/fbx-single-color branch July 24, 2020 20:01
@two-one-five two-one-five mentioned this pull request Sep 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HifiExperiments HifiExperiments HifiExperiments approved these changes

Assignees
No one assigned
Labels
bugfix CR Approved At least one code reviewer has approved the PR. QA Approved The PR has been tested successfully.
Projects
None yet
Milestone
2020.2.4 Release
Development

Successfully merging this pull request may close these issues.

Renderer ignores vertex colors if only one value is given.
5 participants
@ctrlaltdavid @vircadia-build-notifier @SilverfishVR @HifiExperiments @two-one-five