Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Pass ConfigInterface for mock #533

Closed
wants to merge 3 commits into from

Conversation

helayoty
Copy link
Member

Pass ConfigInterface to SetAuthConfig method to be able to mock

@helayoty helayoty requested a review from Fei-Guo as a code owner April 13, 2023 00:51
@helayoty helayoty temporarily deployed to test April 13, 2023 00:52 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test April 13, 2023 00:52 — with GitHub Actions Inactive
@helayoty helayoty mentioned this pull request Apr 13, 2023
2 tasks
@codecov-commenter
Copy link

Codecov Report

Merging #533 (2d58958) into master (e24d23b) will increase coverage by 0.72%.
The diff coverage is 58.82%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #533      +/-   ##
==========================================
+ Coverage   62.35%   63.08%   +0.72%     
==========================================
  Files          15       15              
  Lines        2473     2473              
==========================================
+ Hits         1542     1560      +18     
+ Misses        816      794      -22     
- Partials      115      119       +4     
Impacted Files Coverage Δ
pkg/provider/config.go 68.29% <0.00%> (ø)
pkg/provider/aci.go 66.18% <50.00%> (ø)
pkg/network/aci_network.go 26.61% <66.66%> (+6.47%) ⬆️
pkg/auth/auth_config.go 61.53% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@helayoty helayoty temporarily deployed to test April 13, 2023 02:39 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test April 13, 2023 02:39 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test April 13, 2023 14:27 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test April 13, 2023 14:27 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test April 13, 2023 18:00 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test April 13, 2023 18:00 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test April 13, 2023 18:01 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test April 13, 2023 18:02 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test April 13, 2023 18:02 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test April 13, 2023 18:02 — with GitHub Actions Inactive
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
@helayoty helayoty temporarily deployed to test April 13, 2023 18:57 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test April 13, 2023 18:57 — with GitHub Actions Inactive
@helayoty helayoty closed this Apr 13, 2023
@helayoty helayoty deleted the auth-pass-interface branch April 13, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants