Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8.0 Release Tracker #3983

Closed
18 tasks done
tgorkin opened this issue Dec 9, 2019 · 11 comments
Closed
18 tasks done

8.0 Release Tracker #3983

tgorkin opened this issue Dec 9, 2019 · 11 comments
Milestone
8.0

Comments

@tgorkin
Copy link
Contributor

tgorkin commented Dec 9, 2019 •
edited by Pessimistress
Loading

Testing procedure

  • access staged doc website
  • go through all examples and verify functionality in control panels
  • go through all layers in JSON playground
  • check visible results for regressions and console for errors/warnings
  • add results of testing as comments on this issue
@tgorkin tgorkin added this to the 8.0 milestone Dec 10, 2019
@Pessimistress Pessimistress mentioned this issue Dec 11, 2019
Merged
@Pessimistress
Copy link
Collaborator

Pessimistress commented Dec 13, 2019 •
edited
Loading

iOS:

  • 3D surface example: text labels are up side down
  • ScreenGridLayer example: aggregation result is not aligned with the base map

E775E69D-F924-4B1D-A485-AAE380A2D601

@Pessimistress Pessimistress mentioned this issue Dec 13, 2019
Merged
@1chandu 1chandu mentioned this issue Dec 16, 2019
Merged
@1chandu
Copy link
Contributor

1chandu commented Dec 16, 2019 •
edited
Loading

  • TripsLayer Example: when rotating only base map is rotated
  • Tile3DLayer, tiles don't load while rotating the camera

Screen Shot 2019-12-16 at 1 00 53 PM

Screen Shot 2019-12-16 at 1 00 37 PM

  • Playground : none of the examples render, except GeoJson.

This was referenced Dec 16, 2019
Merged
Merged
Merged
@Pessimistress
Copy link
Collaborator

Pessimistress commented Dec 16, 2019 •
edited
Loading

  • tooltips are behind the canvas when running example apps standalone

@Pessimistress Pessimistress mentioned this issue Dec 17, 2019
Merged
@tsherif
Copy link
Contributor

tsherif commented Dec 17, 2019 •
edited by Pessimistress
Loading

Chrome:

  • Screen grid layer example not working: dist.min.js:1 WebGL: INVALID_ENUM: blendEquationSeparate: invalid mode
  • A lot of Unable to perform style diff: Unimplemented: setLayerProperty, setLayerProperty...
  • Contour layer doc example not working (no console errors)
  • GPUGrid layer doc example not working (no console errors)
  • GPUGrid layer doc example not working (no console errors)
  • ScreenGrid layer doc example not working (no console errors)

@tsherif
Copy link
Contributor

tsherif commented Dec 17, 2019 •
edited by Pessimistress
Loading

Edge:

  • Website does not load SCRIPT1028: SCRIPT1028: Expected identifier, string or number Looks like it's an object spread operation (not supported in Edge). This is the minified code that produces it:
,{map:s=window.mapboxgl}=e;super({canvas:n,...e}),s&&s.Map?this._map=o&&new r.a(Object.assign({},e,{viewState:i,container:t,mapboxgl:s}

@tsherif
Copy link
Contributor

tsherif commented Dec 17, 2019

IE:

  • Website does not load SCRIPT1004: Expected ';' Looks like it's async/await calls. Here's the minified code that's producing it:
turn e.map((function(e){return l(e,t)}))}async function s(e,t){return await Promise.all(e.map(e=>h(e,t)))}function u(e,t){const n=l(e.object,t);return e.computed?[n,n[l(e.property,t)]]:[n,n[e.property.name]]}async function c(e,t){const n=aw

@xintongxia
Copy link
Contributor

xintongxia commented Dec 17, 2019 •
edited by Pessimistress
Loading

Safari

  • Tile3DLayer
[Error] WebGL: drawArraysInstanced: texture bound to texture unit 0 is not renderable. It maybe non-power-of-2 and have incompatible texture filtering or is not 'texture complete', or it is a float/half-float type with linear filtering and without the relevant float/half-float linear extension enabled.
	drawArraysInstancedANGLE
	(anonymous function) (dist.min.js:11:346509)
	(anonymous function) (dist.min.js:11:346312)
	(anonymous function) (dist.min.js:6:113997)
	value (dist.min.js:1:79526)
	value (dist.min.js:6:113898)
	value (dist.min.js:11:346176)
	value (dist.min.js:6:125937)
	value (dist.min.js:6:262990)
	(anonymous function) (dist.min.js:1:279026)
	value (dist.min.js:1:278989)
	(anonymous function) (dist.min.js:1:224295)
	forEach
	value (dist.min.js:1:224018)
	(anonymous function) (dist.min.js:1:223360)
	forEach
	value (dist.min.js:1:223255)
	value (dist.min.js:6:92788)
	value (dist.min.js:6:184810)
	value (bundle.js:92:182350)
	value (bundle.js:92:181973)
	za (bundle.js:22:82947)
	Ha (bundle.js:22:85507)
	(anonymous function) (bundle.js:22:98714)
	(anonymous function) (bundle.js:31:3196)
	Ms (bundle.js:22:98671)
	Ts (bundle.js:22:98425)
	xs (bundle.js:22:97770)
	_s (bundle.js:22:96791)
	Za (bundle.js:22:95665)
	enqueueForceUpdate (bundle.js:22:45368)
	(anonymous function) (bundle.js:14:2010)
	value (bundle.js:92:182525)
	value
	value (dist.min.js:6:180021)
	value (dist.min.js:6:185547)
	value
	value (dist.min.js:6:158653)
	value (dist.min.js:6:155842)
	t (dist.min.js:6:157835)
  • when switching different layer examples
Unable to perform style diff: Unimplemented: setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty, setLayerProperty..  Rebuilding the style from scratch.

  • Submodule Api Reference link invalid @deck.gl/json JsonLayer
    https://raw.githubusercontent.com/uber/deck.gl/master/docs/api-reference/json/json-layer.md
    Failed to load resource: the server responded with a status of 404 (Not Found)

  • deck.gl API Reference GreatCircleLayer

[Error] WebGL: INVALID_OPERATION: drawArraysInstanced: attempt to access out of bounds arrays
	drawArraysInstancedANGLE
	(anonymous function) (dist.min.js:11:346509)
	(anonymous function) (dist.min.js:11:346312)
	(anonymous function) (dist.min.js:6:113997)
	value (dist.min.js:1:79526)
	value (dist.min.js:6:113898)
	value (dist.min.js:11:346176)
	value (dist.min.js:6:125937)
	value (dist.min.js:6:273946)
	(anonymous function) (dist.min.js:1:279026)
	c (dist.min.js:1:211442)
	value (dist.min.js:1:278989)
	(anonymous function) (dist.min.js:1:224295)
	forEach
	value (dist.min.js:1:224018)
	(anonymous function) (dist.min.js:1:223360)
	forEach
	value (dist.min.js:1:223255)
	(anonymous function) (dist.min.js:6:104044)
	c (dist.min.js:1:211442)
	value (dist.min.js:6:103516)
	value (dist.min.js:6:149069)
	value (dist.min.js:6:146665)
	value (dist.min.js:6:180678)
	value (dist.min.js:6:183047)
	value
	value (dist.min.js:6:185533)
	value
	value (dist.min.js:6:158653)
	value (dist.min.js:6:155842)
	t (dist.min.js:6:157835)
  • TileLayer

Most of the control panel options do not apply.

autoHighlight
highlightColor
lineWidthMinPixels
opacity
pickable
stroked

@1chandu 1chandu mentioned this issue Dec 17, 2019
Merged
@tsherif
Copy link
Contributor

tsherif commented Dec 17, 2019 •
edited by Pessimistress
Loading

@Pessimistress any reason that wouldn't be transpiled anymore?

@Pessimistress Pessimistress mentioned this issue Dec 17, 2019
Merged
@tsherif
Copy link
Contributor

tsherif commented Dec 17, 2019 •
edited by Pessimistress
Loading

This was referenced Dec 18, 2019
Merged
Merged
@Pessimistress
Copy link
Collaborator

Pessimistress commented Dec 18, 2019 •
edited
Loading

Gallery issues:

  • IconLayer example: not rendering
  • PointCloudLayer example: not rendering
  • Viewport transition example: no transition

This was referenced Dec 18, 2019
Merged
Merged
@1chandu
Copy link
Contributor

1chandu commented Dec 19, 2019 •
edited
Loading

AggregationLayer issues:

  • Heatmap/Screengrid Examples don't render on data load (need to trigger another update to see data)
  • GPUGridLayer cell positioning is wrong on when cellSize is changed (layer-browser)
  • Heatmap layer doesn't render when zoom is 12 or more.

@1chandu 1chandu mentioned this issue Dec 20, 2019
Merged
This was referenced Dec 20, 2019
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0
Development

No branches or pull requests
5 participants
@tsherif @tgorkin @Pessimistress @xintongxia @1chandu