Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AggregationLayer: various fixes #4062

Merged
merged 6 commits into from
Dec 20, 2019
Merged

AggregationLayer: various fixes #4062

merged 6 commits into from
Dec 20, 2019

Conversation

1chandu
Copy link
Contributor

@1chandu 1chandu commented Dec 20, 2019

For #3983

Background

  • Fix aggregation dirty flags, so when data is loaded, aggregation is re-run.
  • Use alignment for translation only, use actual bounding box for calculating grid dimensions.
  • Fix translation and gridOrigin setttings
  • Fix GPUGridLayer's sublayer attribute settings.

Change List

  • Fix aggregation dirty flags.
  • Use alignment for translation only.
  • Fix bounding box translation
  • Fix GPUGridLayer attribute setting

@1chandu 1chandu merged commit 8815f19 into master Dec 20, 2019
@1chandu 1chandu deleted the AggregationFixes branch December 20, 2019 07:53
chrisgervang pushed a commit that referenced this pull request Jan 31, 2020
@1chandu @chrisgervang
AggregationLayer: various fixes (#4062)
8c6d528 
* Fix aggregation dirty flags.
* Use alignment for translation only.
* Fix bounding box translation
* Fix GPUGridLayer attribute setting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pessimistress Pessimistress Pessimistress approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1chandu @Pessimistress