Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layer bug fixes #4040

Merged
merged 2 commits into from
Dec 17, 2019
Merged

Layer bug fixes #4040

merged 2 commits into from
Dec 17, 2019

Conversation

Pessimistress
Copy link
Collaborator

For #3983

Change List

  • Remove reference to deprecated COORDINATE_SYSTEM.IDENTITY (fixes console warning)
  • Move picking highlight related code out of updateState(). It depends on this.getModels() being populated, but we don't have control over whether or when super.updateState() is called by the layer. (fixes BitmapLayer autohighlight)
  • Add DECKGL_FILTER_COLOR hook to BitmapLayer vertex shader (fixes picking)
  • Update GreatCircleLayer vertex shader (base layer changed to use vec3 64low attributes)
  • Rerender sublayers when TileLayer's props change

@coveralls
Copy link

coveralls commented Dec 17, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.001%) to 83.103% when pulling af332cb on x/website-fixes into 6c49484 on master.

@Pessimistress Pessimistress merged commit f008860 into master Dec 17, 2019
@Pessimistress Pessimistress deleted the x/website-fixes branch December 17, 2019 22:57
tgorkin added a commit that referenced this pull request Dec 18, 2019
@tgorkin
Merge branch 'master' into tgorkin/gatsby-examples
640a37f 
* master:
  v8.0.0-beta.2
  Layer bug fixes (#4040)
  Fix WebGL BlendEquation warnings (#4037)
  Support preprojection in PolygonTesselator (#4035)
  [Fix]: CPU Aggregation: filter out points outside of viewport. (#4026)
  React module fixes (#4032)
  Bump math.gl and probe.gl dependencies (#4029)
  RFC: Mobile Platform Support (#3999)
  Fix playground examples (#4030)
chrisgervang pushed a commit that referenced this pull request Jan 31, 2020
@Pessimistress @chrisgervang
Layer bug fixes (#4040)
c6e02b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xintongxia xintongxia xintongxia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pessimistress @coveralls @xintongxia