Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Looks like these methods have been deprecated #4049

Merged
merged 1 commit into from
Dec 19, 2019
Merged

Looks like these methods have been deprecated #4049

merged 1 commit into from
Dec 19, 2019

Conversation

lukemcgregor
Copy link
Contributor

For #

Background

Change List

@claassistantio
Copy link

claassistantio commented Dec 19, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.912% when pulling 3eb599b on lukemcgregor:patch-1 into 9c2a962 on uber:master.

Pessimistress
Pessimistress approved these changes Dec 19, 2019
View reviewed changes
Copy link
Collaborator

@Pessimistress Pessimistress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Pessimistress Pessimistress merged commit bf5cee0 into visgl:master Dec 19, 2019
Pessimistress pushed a commit that referenced this pull request Dec 20, 2019
@lukemcgregor
Looks like these methods have been deprecated (#4049)
e0c0752
chrisgervang pushed a commit that referenced this pull request Jan 31, 2020
@lukemcgregor @chrisgervang
Looks like these methods have been deprecated (#4049)
8cc04e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pessimistress Pessimistress Pessimistress approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukemcgregor @claassistantio @coveralls @Pessimistress