-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(engine): Transform → BufferTransform + TextureTransform #1896
Conversation
My intentions here are:
In comparison to the current implementation I'm hoping to avoid all of the shader transformation happening in code like I'm hoping this can considerably simplify the code in preparation for API changes in v9.1. I realize there may be some wrinkles in this plan. I did for example see code in deckgl running transform feedback for transitions and also writing output to a 1-pixel fragment shader to detect when a transition has completed. That can probably be handled here but if there are other complicating factors it would be good to know! I'd also like to try to ensure that the important functionality of the Transform classes is verified directly with unit tests, which will make future changes much easier. |
d263a9f
to
06f719f
Compare
To do:
|
06f719f
to
7bf0630
Compare
This should be ready for review. I think the remaining TODOs in code represent open questions, related to my comment above. Thoughts or preferences would be welcome. In the meantime I'll do some tests locally updating deckgl against this PR, to see if I have further opinions on the TODOs. This is a 'breaking' change to the previous transform API and is, hopefully:
|
5357995
to
2284843
Compare
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
5be0b8b
to
958fe33
Compare
958fe33
to
52d9794
Compare
Co-authored-by: felixpalmer <felixpalmer@gmail.com>
Work in progress. Adding more functionality required for deckgl aggregation layers.
Changes:
Transform
→BufferTransform
TextureTransform
class