Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracker: 9.0 release #1501

Closed
31 tasks done
ibgreen opened this issue Sep 9, 2021 · 5 comments
Closed
31 tasks done

Tracker: 9.0 release #1501

ibgreen opened this issue Sep 9, 2021 · 5 comments
Assignees

Comments

@ibgreen
Copy link
Collaborator

ibgreen commented Sep 9, 2021

v9.0

Bugs

https://github.com/visgl/luma.gl/issues?q=is%3Aissue+is%3Aopen+milestone%3A9.0.0

Docs / Website

Build

API

Tests

Examples

  • Simplify tutorial gltf example and write tutorial page? - @felixpalmer -
  • Make WebGPU examples work again - @ibgreen - ShaderLayout refactor for deck.gl broke them
  • Fix example layout issue (should not take full screen)
  • Fix WebGL / WebGPU switcher in website @zbigg
  • Fix example index page scrolling issue @zbigg
  • New tutorial gltf example - @felixpalmer -
@ibgreen ibgreen pinned this issue Nov 15, 2021
@ibgreen ibgreen changed the title Tracker: 8.6 release Tracker: 8.7 release Dec 9, 2021
@ibgreen ibgreen changed the title Tracker: 8.7 release Tracker: 9.0 release Jan 23, 2022
@donmccurdy
Copy link
Collaborator

Restore fp64 tests

I see these tests may have been restored in 5435295, is this still an issue?

@ibgreen
Copy link
Collaborator Author

ibgreen commented Nov 30, 2023

I think that PR is just moving the shader module file structure around. Those tests are most likely still commented out.

@donmccurdy
Copy link
Collaborator

donmccurdy commented Nov 30, 2023

I see – so these blocks?

if (webgl2Device?.info.gpu === 'apple') {
t.comment('apple GPU has precision issues')
} else {

I'll take a look if no one is working on that already.

More links

On closer look, those tests depend on transform feedback, which is still an open task. I'll start chipping away at Ib's suggestion, "Most of the tests should be moved from webgl into core-tests module where they can run on both webgl and later webgpu backends", instead.

@donmccurdy
Copy link
Collaborator

CommandEncoder: encapsulate webgl readPixel()`

@ibgreen I've restored tests for copyTextureToBuffer in #1885, that seems to be working, is anything else required for this task?

@ibgreen
Copy link
Collaborator Author

ibgreen commented Dec 19, 2023

CommandEncoder: encapsulate webgl readPixel()`

@ibgreen I've restored tests for copyTextureToBuffer in #1885, that seems to be working, is anything else required for this task?

Ultimately the reason we did this is to make applications perform texture reads through a portable API. Right now apps (and deck.gl) have to import webgl module. See e.g. https://github.com/visgl/luma.gl/blob/master/examples/showcase/instancing/app.ts#L6

You could try and see if it is not too hard to replace all use of readPixels, but then again we don't necessarily need to solve this completely in 9.0, we could come back to this in 9.1.

Still, it is good to have this enabler in place!

@ibgreen ibgreen unpinned this issue Mar 25, 2024
This was referenced Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants