Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove WebGL1 support #1933

Merged
merged 8 commits into from
Feb 17, 2024
Merged

chore: Remove WebGL1 support #1933

merged 8 commits into from
Feb 17, 2024

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Jan 26, 2024

For #

Background

  • Last steering meeting indicated preliminary agreement around removing WebGL1 support.
  • (deck.gl v9 won't run on WebGL1 regardless as it uses uniform buffers etc, and we want our development bandwidth focused on WebGPU, not WebGL1).
  • This PR will be discussed in the Feb 1 meeting.
  • The changes can land in 9.0 or 9.1, but we probably do not want to wait until v10.

Change List

  • Remove WebGL1 support
  • Remove GLSL 1.00 support
  • Remove headless-gl support

Remaining / Follow ups

  • test cleanups
  • doc cleanup
  • website cleanup
  • Remove GLSL 3.00 -> 1.00 shader transpilation

@ibgreen
Copy link
Collaborator Author

ibgreen commented Jan 28, 2024

@donmccurdy I am getting some test failures in the TextureTransform class, I can't really see what changed - and those tests were already WebGL2 only before this PR. Perhaps we can pair up early next week? It would be good to have this PR ready to merge for the Thursday open vis meeting.

@ibgreen ibgreen mentioned this pull request Jan 29, 2024
31 tasks
@donmccurdy
Copy link
Collaborator

@ibgreen sorry I missed this earlier! Yes, I think I can take a look at the failing TextureTransform tests tomorrow morning.

@ibgreen ibgreen changed the title chore: Remove WebGL1 support (POC for discussion) chore: Remove WebGL1 support Feb 15, 2024
@ibgreen ibgreen marked this pull request as ready for review February 17, 2024 20:07
@ibgreen ibgreen merged commit 9089c41 into master Feb 17, 2024
1 of 2 checks passed
@ibgreen ibgreen deleted the ib/remove-webgl1 branch February 17, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants