Fix babel-plugin-inline-webgl-constants

[donmccurdy]

Fixes for babel-plugin-inline-webgl-constants in v9. I haven't published the plugin to npm, so I haven't added it back to babel.config.cjs yet either. When building locally, I needed to disable the ocular-clean step before each build, so that the constants are there when the plugin imports them. I don't know if that would be an issue once the plugin is published to npm? Or should we be doing something to ensure @luma.gl/constants builds first, without this plugin?

Changes:

• Handle both default and non-default imports
• Skip certain expressions so that including the babel plugin when building @luma.gl/constants does not fail
• Update and re-enable unit tests

---

• From Tracker: 9.0 release #1501

[ibgreen]

If I recall correctly, in this module we used to work around the "inliner" simply by importing the modules under a different name `import {GL as GLEnum, GL as GL_CONSTANTS, ...}.

The webgl-types.h file is new for v9 so it hasn't been done there (as the inliner has been disabled). Maybe a rename is all that is needed?

The main other thing that changed in the constants module for v9 is that we had to change from GL being a default export to a named export, as default exports from modules have issues when using ES modules (package type "module").

[donmccurdy]

I'll take a closer look on Monday, but I think renaming GL as GLEnum would be an alternative to how I'm using EXCLUDED_TYPES here. I'd be fine with either of those solutions. This PR does handle the "default export to a named export" change.

I'm still not quite sure how the babel plugin can import @luma.gl/constants before @luma.gl/constants is built, and since it's a part of that build process, it seems like a circular dependency? But if that hasn't been an issue in the past, maybe it isn't a real problem.

[ibgreen]

Note that the dev-modules folder is not part of the synchronized publishing process that we use for the main packages in the modules directory. You publish the dev modules separately, individually, "manually" at any time.

[donmccurdy]

I think I've resolved the open issues. Using a "GLEnum" alias instead of "EXCLUDED_TYPES" feels like a good approach to me. The rest of the changes are required to support the ESM import syntax.

For future reference, my steps to make changes in this plugin were:

1. Run yarn build with the plugin disabled
2. Disable ocular-clean in package.json#scripts build macro
3. Enable plugin './dev-modules/babel-plugin-inline-webgl-constants/index.js' in babel.config.js
4. Run yarn && yarn build from dev-modules/babel-plugin-inline-webgl-constants
5. Run yarn build and/or yarn test from project root

The unit tests are especially helpful in this case!

[donmccurdy]

Someone else may need to publish babel-plugin-inline-webgl-constants to npm for me, before this can be enabled in babel.config.js. For now I've made the changes but not enabled it in babel config.

[ibgreen]

LGTM, Let's get a stamp from @Pessimistress as well.

[donmccurdy]

Thanks! I'll publish the plugin and merge the PR tomorrow.

[donmccurdy]

Seeing that the plugin's versioning is synced with the other luma.gl packages, I'm not confident publishing a release of the whole monorepo myself yet. I'll follow up about that in Slack.