[Feature / cli] Add template / option for solidjs in cli

[ampmonteiro]

Description

Since all almost well known frameworks / libraries exist as template in vite, the only that is missing is solidjs.

Since official way of install solidjs, from solid website, already use vite,
i think make sense also exist in vite cli as a template.

As it has a benefit for solidjs itself, since it could turn into official way as well and would be centralized in vite, instead of using

npx degit solidjs/templates/js my-app

thanks

Suggested solution

Just add their template js and ts into vite cli options.

Alternative

No response

Additional context

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

[fi3ework]

IMO it's a good idea, and an interesting thing I found that there are already template-ssr-solid and template-ssr-solid-ts in https://github.com/bluwy/create-vite-extra but lack a template-solid 😜. Was it intentional? @bluwy

[bluwy]

I wanted to add solid templates to create-vite-extra but never got around adding them, but for solid's case, I think we discussed before that it's probably fine to add it in create-vite directly.

[github-actions]

Hello @ampmonteiro. We like your proposal/feedback and would appreciate a contribution via a Pull Request by you or another community member. We thank you in advance for your contribution and are looking forward to reviewing it!

[fi3ework]

https://discord.com/channels/804011606160703521/902594605512548442/1065513317386420255 FYI, found a discussion about this lately.

[ampmonteiro]

Hi,

solidjs team already create the plugins with js and ts for vite 4, if you see the Getting Started page of solidjs website and installed in your machine like i did.

here the js template vite config:

import { defineConfig } from 'vite';
import solidPlugin from 'vite-plugin-solid';

export default defineConfig({
  plugins: [solidPlugin()],
  server: {
    port: 3000,
  },
  build: {
    target: 'esnext',
    },
  },
});

My recommendations is someone of vite team talk to someone of solidjs team.

[AbdelrahmanDwedar]

Hi,

solidjs team already create the plugins with js and ts for vite 4, if you see the Getting Started page of solidjs website and installed in your machine like i did.

here the js template vite config:

import { defineConfig } from 'vite';
import solidPlugin from 'vite-plugin-solid';

export default defineConfig({
  plugins: [solidPlugin()],
  server: {
    port: 3000,
  },
  build: {
    target: 'esnext',
    },
  },
});

My recommendations is someone of vite team talk to someone of solidjs team.

Does the exact same work for typescript version?

[ampmonteiro]

Hi @AbdelrahmanDwedar ,

it seams that you already have the answer, since you already start a pull request.

Another thing i would like to say is that the templates ( js and ts) should, in my opinion, have same structure (like adding the public folder and components folder) and use as a demo the counter app.
thanks.

[AbdelrahmanDwedar]

We did that things but I don't think that the vite team wants the components directory. They seem to have everything as simple & as lightweight as possible.

We followed the same structure as the React app, the exact same one even the images places.

[ampmonteiro]

@AbdelrahmanDwedar,

ok, In react and preact templates, the component folder does not exist.

Only thing missing is / was public folder.

[AbdelrahmanDwedar]

The public folder was added and the template should be good right now.

There's just a problem with the rumtime kn Windows, tried to search for the reason behind that.

[ampmonteiro]

@AbdelrahmanDwedar

ok, thanks.