Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: standardize create-vite vanilla templates #16183

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

n-ce
Copy link

@n-ce n-ce commented Mar 17, 2024

Description

  • Includes removal of innerHTML which is not considered a safe practice, replaces it with textContent.
  • Reduces usage of javascript / typescript to add to DOM, instead relies on standard HTML.
  • Replaces div#app with standard main tag
  • As a side effect there might be a slight increase in performance, but that is not the goal here.

Additional context

This PR is meant to be squash merged


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

stackblitz bot commented Mar 17, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@n-ce n-ce changed the title create-vite : standardize vanilla templates refactor : standardize create-vite vanilla templates Mar 17, 2024
@n-ce n-ce changed the title refactor : standardize create-vite vanilla templates refactor: standardize create-vite vanilla templates Mar 17, 2024
@bluwy
Copy link
Member

bluwy commented Mar 18, 2024

I'm not sure if we need this change. The code is meant to mimic how the other framework templates like React and Vue renders things. This makes it less consistent with the other templates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants