chore(create-vite): change directory structure of template-vanilla for consistency
#18716
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nozomuikuta
changed the title
src directory for consistencytemplate-vanilla for consistency
bluwy
approved these changes
Nov 20, 2024
nozomuikuta
changed the title
template-vanilla for consistencytemplate-vanilla for consistency
|
@bluwy |
|
The reason was to show case the most minimal project structure.
That said, I'm personally fine with making it consistent. |
sapphi-red
added
feat: create-vite
|
Just want to leave a note of support here. It made sense when Vite started to have a very simple starter to show you could create a vite app without even a config. But I think we are better served now by having a config and aligning with all others. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No related issues.
Maybe related to #16183.
I found that
template-vanilladoesn't havesrcdirectory while the other templates do, and I didn't find any technical necessity for it to be like that.This PR is just to make templates directory structure consistent.
Note that I added
!in the commit message (PR title) because I guess this change is a breaking one.