fix(css): fix directory index import in sass modern api #17960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hi-ogawa
commented
Aug 28, 2024
Comment on lines
-1098
to
-1103
| const id = args[0] | ||
| if (id.startsWith('file://')) { | ||
| const fileUrl = new URL(id) | ||
| if (fs.existsSync(fileUrl)) { | ||
| return fileURLToPath(fileUrl) | ||
| } |
There was a problem hiding this comment.
To explain what was happening, sass modern api calls a custom importer twice for each @import resolution. I made a simple test code here without Vite https://github.com/hi-ogawa/reproductions/tree/main/vite-17960-sass-legacy-directory-import
For the test case @import "./dir", importer's canonicalize is called twice:
// 1st call
url: 'file:///abs-path-to/scss-dir/dir',
importer: undefined
// 2nd call
url: 'dir'
importer: 'file://abs-path-to-/scss-dir/main.scss'Before file:// check is introduced in #17909, @import "./dir" was working due to 2nd call of canonicalize. After #17909, it's breaking since it's resolving to a directory by the 1st call.
bluwy
approved these changes
Sep 1, 2024
patak-dev
approved these changes
Sep 2, 2024
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Sep 11, 2024
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | vite | 5.4.2 | 5.4.3 | ## [v5.4.3](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small543-2024-09-03-small) - fix: allow getting URL of JS files in publicDir ([#17915](vitejs/vite#17915)) ([943ece1](vitejs/vite@943ece1)), closes [#17915](vitejs/vite#17915) - fix: cjs warning respect the logLevel flag ([#17993](vitejs/vite#17993)) ([dc3c14f](vitejs/vite@dc3c14f)), closes [#17993](vitejs/vite#17993) - fix: improve CJS warning trace information ([#17926](vitejs/vite#17926)) ([5c5f82c](vitejs/vite@5c5f82c)), closes [#17926](vitejs/vite#17926) - fix: only remove entry assets handled by Vite core ([#17916](vitejs/vite#17916)) ([ebfaa7e](vitejs/vite@ebfaa7e)), closes [#17916](vitejs/vite#17916) - fix: waitForRequestIdle locked ([#17982](vitejs/vite#17982)) ([ad13760](vitejs/vite@ad13760)), closes [#17982](vitejs/vite#17982) - fix(css): fix directory index import in sass modern api ([#17960](vitejs/vite#17960)) ([9b001ba](vitejs/vite@9b001ba)), closes [#17960](vitejs/vite#17960) - fix(css): fix sass `file://` reference ([#17909](vitejs/vite#17909)) ([561b940](vitejs/vite@561b940)), closes [#17909](vitejs/vite#17909) - fix(css): fix sass modern source map ([#17938](vitejs/vite#17938)) ([d428e7e](vitejs/vite@d428e7e)), closes [#17938](vitejs/vite#17938) - fix(deps): bump tsconfck ([#17990](vitejs/vite#17990)) ([8c661b2](vitejs/vite@8c661b2)), closes [#17990](vitejs/vite#17990) - fix(html): rewrite assets url in <template> ([#17988](vitejs/vite#17988)) ([413c86a](vitejs/vite@413c86a)), closes [#17988](vitejs/vite#17988) - fix(preload): add crossorigin attribute in CSS link tags ([#17930](vitejs/vite#17930)) ([15871c7](vitejs/vite@15871c7)), closes [#17930](vitejs/vite#17930) - chore: reduce diffs with v6 branch ([#17942](vitejs/vite#17942)) ([bf9065a](vitejs/vite@bf9065a)), closes [#17942](vitejs/vite#17942) - chore(deps): update all non-major dependencies ([#17945](vitejs/vite#17945)) ([cfb621e](vitejs/vite@cfb621e)), closes [#17945](vitejs/vite#17945) - chore(deps): update all non-major dependencies ([#17991](vitejs/vite#17991)) ([0ca53cf](vitejs/vite@0ca53cf)), closes [#17991](vitejs/vite#17991)
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Sep 13, 2024
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | vite | 5.4.2 | 5.4.4 | ## [v5.4.4](https://github.com/vitejs/vite/releases/tag/v5.4.4) Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v5.4.4/packages/vite/CHANGELOG.md) for details. ## [v5.4.3](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small543-2024-09-03-small) - fix: allow getting URL of JS files in publicDir ([#17915](vitejs/vite#17915)) ([943ece1](vitejs/vite@943ece1)), closes [#17915](vitejs/vite#17915) - fix: cjs warning respect the logLevel flag ([#17993](vitejs/vite#17993)) ([dc3c14f](vitejs/vite@dc3c14f)), closes [#17993](vitejs/vite#17993) - fix: improve CJS warning trace information ([#17926](vitejs/vite#17926)) ([5c5f82c](vitejs/vite@5c5f82c)), closes [#17926](vitejs/vite#17926) - fix: only remove entry assets handled by Vite core ([#17916](vitejs/vite#17916)) ([ebfaa7e](vitejs/vite@ebfaa7e)), closes [#17916](vitejs/vite#17916) - fix: waitForRequestIdle locked ([#17982](vitejs/vite#17982)) ([ad13760](vitejs/vite@ad13760)), closes [#17982](vitejs/vite#17982) - fix(css): fix directory index import in sass modern api ([#17960](vitejs/vite#17960)) ([9b001ba](vitejs/vite@9b001ba)), closes [#17960](vitejs/vite#17960) - fix(css): fix sass `file://` reference ([#17909](vitejs/vite#17909)) ([561b940](vitejs/vite@561b940)), closes [#17909](vitejs/vite#17909) - fix(css): fix sass modern source map ([#17938](vitejs/vite#17938)) ([d428e7e](vitejs/vite@d428e7e)), closes [#17938](vitejs/vite#17938) - fix(deps): bump tsconfck ([#17990](vitejs/vite#17990)) ([8c661b2](vitejs/vite@8c661b2)), closes [#17990](vitejs/vite#17990) - fix(html): rewrite assets url in <template> ([#17988](vitejs/vite#17988)) ([413c86a](vitejs/vite@413c86a)), closes [#17988](vitejs/vite#17988) - fix(preload): add crossorigin attribute in CSS link tags ([#17930](vitejs/vite#17930)) ([15871c7](vitejs/vite@15871c7)), closes [#17930](vitejs/vite#17930) - chore: reduce diffs with v6 branch ([#17942](vitejs/vite#17942)) ([bf9065a](vitejs/vite@bf9065a)), closes [#17942](vitejs/vite#17942) - chore(deps): update all non-major dependencies ([#17945](vitejs/vite#17945)) ([cfb621e](vitejs/vite@cfb621e)), closes [#17945](vitejs/vite#17945) - chore(deps): update all non-major dependencies ([#17991](vitejs/vite#17991)) ([0ca53cf](vitejs/vite@0ca53cf)), closes [#17991](vitejs/vite#17991)
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Sep 14, 2024
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | vite | 5.4.2 | 5.4.5 | ## [v5.4.5](https://github.com/vitejs/vite/releases/tag/v5.4.5) Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v5.4.5/packages/vite/CHANGELOG.md) for details. ## [v5.4.4](https://github.com/vitejs/vite/releases/tag/v5.4.4) Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v5.4.4/packages/vite/CHANGELOG.md) for details. ## [v5.4.3](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small543-2024-09-03-small) - fix: allow getting URL of JS files in publicDir ([#17915](vitejs/vite#17915)) ([943ece1](vitejs/vite@943ece1)), closes [#17915](vitejs/vite#17915) - fix: cjs warning respect the logLevel flag ([#17993](vitejs/vite#17993)) ([dc3c14f](vitejs/vite@dc3c14f)), closes [#17993](vitejs/vite#17993) - fix: improve CJS warning trace information ([#17926](vitejs/vite#17926)) ([5c5f82c](vitejs/vite@5c5f82c)), closes [#17926](vitejs/vite#17926) - fix: only remove entry assets handled by Vite core ([#17916](vitejs/vite#17916)) ([ebfaa7e](vitejs/vite@ebfaa7e)), closes [#17916](vitejs/vite#17916) - fix: waitForRequestIdle locked ([#17982](vitejs/vite#17982)) ([ad13760](vitejs/vite@ad13760)), closes [#17982](vitejs/vite#17982) - fix(css): fix directory index import in sass modern api ([#17960](vitejs/vite#17960)) ([9b001ba](vitejs/vite@9b001ba)), closes [#17960](vitejs/vite#17960) - fix(css): fix sass `file://` reference ([#17909](vitejs/vite#17909)) ([561b940](vitejs/vite@561b940)), closes [#17909](vitejs/vite#17909) - fix(css): fix sass modern source map ([#17938](vitejs/vite#17938)) ([d428e7e](vitejs/vite@d428e7e)), closes [#17938](vitejs/vite#17938) - fix(deps): bump tsconfck ([#17990](vitejs/vite#17990)) ([8c661b2](vitejs/vite@8c661b2)), closes [#17990](vitejs/vite#17990) - fix(html): rewrite assets url in <template> ([#17988](vitejs/vite#17988)) ([413c86a](vitejs/vite@413c86a)), closes [#17988](vitejs/vite#17988) - fix(preload): add crossorigin attribute in CSS link tags ([#17930](vitejs/vite#17930)) ([15871c7](vitejs/vite@15871c7)), closes [#17930](vitejs/vite#17930) - chore: reduce diffs with v6 branch ([#17942](vitejs/vite#17942)) ([bf9065a](vitejs/vite@bf9065a)), closes [#17942](vitejs/vite#17942) - chore(deps): update all non-major dependencies ([#17945](vitejs/vite#17945)) ([cfb621e](vitejs/vite@cfb621e)), closes [#17945](vitejs/vite#17945) - chore(deps): update all non-major dependencies ([#17991](vitejs/vite#17991)) ([0ca53cf](vitejs/vite@0ca53cf)), closes [#17991](vitejs/vite#17991)
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Sep 15, 2024
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | vite | 5.4.2 | 5.4.5 | ## [v5.4.5](https://github.com/vitejs/vite/releases/tag/v5.4.5) Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v5.4.5/packages/vite/CHANGELOG.md) for details. ## [v5.4.4](https://github.com/vitejs/vite/releases/tag/v5.4.4) Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v5.4.4/packages/vite/CHANGELOG.md) for details. ## [v5.4.3](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small543-2024-09-03-small) - fix: allow getting URL of JS files in publicDir ([#17915](vitejs/vite#17915)) ([943ece1](vitejs/vite@943ece1)), closes [#17915](vitejs/vite#17915) - fix: cjs warning respect the logLevel flag ([#17993](vitejs/vite#17993)) ([dc3c14f](vitejs/vite@dc3c14f)), closes [#17993](vitejs/vite#17993) - fix: improve CJS warning trace information ([#17926](vitejs/vite#17926)) ([5c5f82c](vitejs/vite@5c5f82c)), closes [#17926](vitejs/vite#17926) - fix: only remove entry assets handled by Vite core ([#17916](vitejs/vite#17916)) ([ebfaa7e](vitejs/vite@ebfaa7e)), closes [#17916](vitejs/vite#17916) - fix: waitForRequestIdle locked ([#17982](vitejs/vite#17982)) ([ad13760](vitejs/vite@ad13760)), closes [#17982](vitejs/vite#17982) - fix(css): fix directory index import in sass modern api ([#17960](vitejs/vite#17960)) ([9b001ba](vitejs/vite@9b001ba)), closes [#17960](vitejs/vite#17960) - fix(css): fix sass `file://` reference ([#17909](vitejs/vite#17909)) ([561b940](vitejs/vite@561b940)), closes [#17909](vitejs/vite#17909) - fix(css): fix sass modern source map ([#17938](vitejs/vite#17938)) ([d428e7e](vitejs/vite@d428e7e)), closes [#17938](vitejs/vite#17938) - fix(deps): bump tsconfck ([#17990](vitejs/vite#17990)) ([8c661b2](vitejs/vite@8c661b2)), closes [#17990](vitejs/vite#17990) - fix(html): rewrite assets url in <template> ([#17988](vitejs/vite#17988)) ([413c86a](vitejs/vite@413c86a)), closes [#17988](vitejs/vite#17988) - fix(preload): add crossorigin attribute in CSS link tags ([#17930](vitejs/vite#17930)) ([15871c7](vitejs/vite@15871c7)), closes [#17930](vitejs/vite#17930) - chore: reduce diffs with v6 branch ([#17942](vitejs/vite#17942)) ([bf9065a](vitejs/vite@bf9065a)), closes [#17942](vitejs/vite#17942) - chore(deps): update all non-major dependencies ([#17945](vitejs/vite#17945)) ([cfb621e](vitejs/vite@cfb621e)), closes [#17945](vitejs/vite#17945) - chore(deps): update all non-major dependencies ([#17991](vitejs/vite#17991)) ([0ca53cf](vitejs/vite@0ca53cf)), closes [#17991](vitejs/vite#17991)
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Sep 16, 2024
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | vite | 5.4.2 | 5.4.5 | ## [v5.4.5](https://github.com/vitejs/vite/releases/tag/v5.4.5) Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v5.4.5/packages/vite/CHANGELOG.md) for details. ## [v5.4.4](https://github.com/vitejs/vite/releases/tag/v5.4.4) Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v5.4.4/packages/vite/CHANGELOG.md) for details. ## [v5.4.3](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small543-2024-09-03-small) - fix: allow getting URL of JS files in publicDir ([#17915](vitejs/vite#17915)) ([943ece1](vitejs/vite@943ece1)), closes [#17915](vitejs/vite#17915) - fix: cjs warning respect the logLevel flag ([#17993](vitejs/vite#17993)) ([dc3c14f](vitejs/vite@dc3c14f)), closes [#17993](vitejs/vite#17993) - fix: improve CJS warning trace information ([#17926](vitejs/vite#17926)) ([5c5f82c](vitejs/vite@5c5f82c)), closes [#17926](vitejs/vite#17926) - fix: only remove entry assets handled by Vite core ([#17916](vitejs/vite#17916)) ([ebfaa7e](vitejs/vite@ebfaa7e)), closes [#17916](vitejs/vite#17916) - fix: waitForRequestIdle locked ([#17982](vitejs/vite#17982)) ([ad13760](vitejs/vite@ad13760)), closes [#17982](vitejs/vite#17982) - fix(css): fix directory index import in sass modern api ([#17960](vitejs/vite#17960)) ([9b001ba](vitejs/vite@9b001ba)), closes [#17960](vitejs/vite#17960) - fix(css): fix sass `file://` reference ([#17909](vitejs/vite#17909)) ([561b940](vitejs/vite@561b940)), closes [#17909](vitejs/vite#17909) - fix(css): fix sass modern source map ([#17938](vitejs/vite#17938)) ([d428e7e](vitejs/vite@d428e7e)), closes [#17938](vitejs/vite#17938) - fix(deps): bump tsconfck ([#17990](vitejs/vite#17990)) ([8c661b2](vitejs/vite@8c661b2)), closes [#17990](vitejs/vite#17990) - fix(html): rewrite assets url in <template> ([#17988](vitejs/vite#17988)) ([413c86a](vitejs/vite@413c86a)), closes [#17988](vitejs/vite#17988) - fix(preload): add crossorigin attribute in CSS link tags ([#17930](vitejs/vite#17930)) ([15871c7](vitejs/vite@15871c7)), closes [#17930](vitejs/vite#17930) - chore: reduce diffs with v6 branch ([#17942](vitejs/vite#17942)) ([bf9065a](vitejs/vite@bf9065a)), closes [#17942](vitejs/vite#17942) - chore(deps): update all non-major dependencies ([#17945](vitejs/vite#17945)) ([cfb621e](vitejs/vite@cfb621e)), closes [#17945](vitejs/vite#17945) - chore(deps): update all non-major dependencies ([#17991](vitejs/vite#17991)) ([0ca53cf](vitejs/vite@0ca53cf)), closes [#17991](vitejs/vite#17991)
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Sep 17, 2024
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | vite | 5.4.2 | 5.4.6 | ## [v5.4.6](https://github.com/vitejs/vite/releases/tag/v5.4.6) Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v5.4.6/packages/vite/CHANGELOG.md) for details. ## [v5.4.5](https://github.com/vitejs/vite/releases/tag/v5.4.5) Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v5.4.5/packages/vite/CHANGELOG.md) for details. ## [v5.4.4](https://github.com/vitejs/vite/releases/tag/v5.4.4) Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v5.4.4/packages/vite/CHANGELOG.md) for details. ## [v5.4.3](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small543-2024-09-03-small) - fix: allow getting URL of JS files in publicDir ([#17915](vitejs/vite#17915)) ([943ece1](vitejs/vite@943ece1)), closes [#17915](vitejs/vite#17915) - fix: cjs warning respect the logLevel flag ([#17993](vitejs/vite#17993)) ([dc3c14f](vitejs/vite@dc3c14f)), closes [#17993](vitejs/vite#17993) - fix: improve CJS warning trace information ([#17926](vitejs/vite#17926)) ([5c5f82c](vitejs/vite@5c5f82c)), closes [#17926](vitejs/vite#17926) - fix: only remove entry assets handled by Vite core ([#17916](vitejs/vite#17916)) ([ebfaa7e](vitejs/vite@ebfaa7e)), closes [#17916](vitejs/vite#17916) - fix: waitForRequestIdle locked ([#17982](vitejs/vite#17982)) ([ad13760](vitejs/vite@ad13760)), closes [#17982](vitejs/vite#17982) - fix(css): fix directory index import in sass modern api ([#17960](vitejs/vite#17960)) ([9b001ba](vitejs/vite@9b001ba)), closes [#17960](vitejs/vite#17960) - fix(css): fix sass `file://` reference ([#17909](vitejs/vite#17909)) ([561b940](vitejs/vite@561b940)), closes [#17909](vitejs/vite#17909) - fix(css): fix sass modern source map ([#17938](vitejs/vite#17938)) ([d428e7e](vitejs/vite@d428e7e)), closes [#17938](vitejs/vite#17938) - fix(deps): bump tsconfck ([#17990](vitejs/vite#17990)) ([8c661b2](vitejs/vite@8c661b2)), closes [#17990](vitejs/vite#17990) - fix(html): rewrite assets url in <template> ([#17988](vitejs/vite#17988)) ([413c86a](vitejs/vite@413c86a)), closes [#17988](vitejs/vite#17988) - fix(preload): add crossorigin attribute in CSS link tags ([#17930](vitejs/vite#17930)) ([15871c7](vitejs/vite@15871c7)), closes [#17930](vitejs/vite#17930) - chore: reduce diffs with v6 branch ([#17942](vitejs/vite#17942)) ([bf9065a](vitejs/vite@bf9065a)), closes [#17942](vitejs/vite#17942) - chore(deps): update all non-major dependencies ([#17945](vitejs/vite#17945)) ([cfb621e](vitejs/vite@cfb621e)), closes [#17945](vitejs/vite#17945) - chore(deps): update all non-major dependencies ([#17991](vitejs/vite#17991)) ([0ca53cf](vitejs/vite@0ca53cf)), closes [#17991](vitejs/vite#17991)
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Sep 18, 2024
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | vite | 5.4.2 | 5.4.6 | ## [v5.4.6](https://github.com/vitejs/vite/releases/tag/v5.4.6) Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v5.4.6/packages/vite/CHANGELOG.md) for details. ## [v5.4.5](https://github.com/vitejs/vite/releases/tag/v5.4.5) Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v5.4.5/packages/vite/CHANGELOG.md) for details. ## [v5.4.4](https://github.com/vitejs/vite/releases/tag/v5.4.4) Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v5.4.4/packages/vite/CHANGELOG.md) for details. ## [v5.4.3](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small543-2024-09-03-small) - fix: allow getting URL of JS files in publicDir ([#17915](vitejs/vite#17915)) ([943ece1](vitejs/vite@943ece1)), closes [#17915](vitejs/vite#17915) - fix: cjs warning respect the logLevel flag ([#17993](vitejs/vite#17993)) ([dc3c14f](vitejs/vite@dc3c14f)), closes [#17993](vitejs/vite#17993) - fix: improve CJS warning trace information ([#17926](vitejs/vite#17926)) ([5c5f82c](vitejs/vite@5c5f82c)), closes [#17926](vitejs/vite#17926) - fix: only remove entry assets handled by Vite core ([#17916](vitejs/vite#17916)) ([ebfaa7e](vitejs/vite@ebfaa7e)), closes [#17916](vitejs/vite#17916) - fix: waitForRequestIdle locked ([#17982](vitejs/vite#17982)) ([ad13760](vitejs/vite@ad13760)), closes [#17982](vitejs/vite#17982) - fix(css): fix directory index import in sass modern api ([#17960](vitejs/vite#17960)) ([9b001ba](vitejs/vite@9b001ba)), closes [#17960](vitejs/vite#17960) - fix(css): fix sass `file://` reference ([#17909](vitejs/vite#17909)) ([561b940](vitejs/vite@561b940)), closes [#17909](vitejs/vite#17909) - fix(css): fix sass modern source map ([#17938](vitejs/vite#17938)) ([d428e7e](vitejs/vite@d428e7e)), closes [#17938](vitejs/vite#17938) - fix(deps): bump tsconfck ([#17990](vitejs/vite#17990)) ([8c661b2](vitejs/vite@8c661b2)), closes [#17990](vitejs/vite#17990) - fix(html): rewrite assets url in <template> ([#17988](vitejs/vite#17988)) ([413c86a](vitejs/vite@413c86a)), closes [#17988](vitejs/vite#17988) - fix(preload): add crossorigin attribute in CSS link tags ([#17930](vitejs/vite#17930)) ([15871c7](vitejs/vite@15871c7)), closes [#17930](vitejs/vite#17930) - chore: reduce diffs with v6 branch ([#17942](vitejs/vite#17942)) ([bf9065a](vitejs/vite@bf9065a)), closes [#17942](vitejs/vite#17942) - chore(deps): update all non-major dependencies ([#17945](vitejs/vite#17945)) ([cfb621e](vitejs/vite@cfb621e)), closes [#17945](vitejs/vite#17945) - chore(deps): update all non-major dependencies ([#17991](vitejs/vite#17991)) ([0ca53cf](vitejs/vite@0ca53cf)), closes [#17991](vitejs/vite#17991)
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Sep 19, 2024
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | vite | 5.4.2 | 5.4.6 | ## [v5.4.6](https://github.com/vitejs/vite/releases/tag/v5.4.6) Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v5.4.6/packages/vite/CHANGELOG.md) for details. ## [v5.4.5](https://github.com/vitejs/vite/releases/tag/v5.4.5) Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v5.4.5/packages/vite/CHANGELOG.md) for details. ## [v5.4.4](https://github.com/vitejs/vite/releases/tag/v5.4.4) Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v5.4.4/packages/vite/CHANGELOG.md) for details. ## [v5.4.3](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small543-2024-09-03-small) - fix: allow getting URL of JS files in publicDir ([#17915](vitejs/vite#17915)) ([943ece1](vitejs/vite@943ece1)), closes [#17915](vitejs/vite#17915) - fix: cjs warning respect the logLevel flag ([#17993](vitejs/vite#17993)) ([dc3c14f](vitejs/vite@dc3c14f)), closes [#17993](vitejs/vite#17993) - fix: improve CJS warning trace information ([#17926](vitejs/vite#17926)) ([5c5f82c](vitejs/vite@5c5f82c)), closes [#17926](vitejs/vite#17926) - fix: only remove entry assets handled by Vite core ([#17916](vitejs/vite#17916)) ([ebfaa7e](vitejs/vite@ebfaa7e)), closes [#17916](vitejs/vite#17916) - fix: waitForRequestIdle locked ([#17982](vitejs/vite#17982)) ([ad13760](vitejs/vite@ad13760)), closes [#17982](vitejs/vite#17982) - fix(css): fix directory index import in sass modern api ([#17960](vitejs/vite#17960)) ([9b001ba](vitejs/vite@9b001ba)), closes [#17960](vitejs/vite#17960) - fix(css): fix sass `file://` reference ([#17909](vitejs/vite#17909)) ([561b940](vitejs/vite@561b940)), closes [#17909](vitejs/vite#17909) - fix(css): fix sass modern source map ([#17938](vitejs/vite#17938)) ([d428e7e](vitejs/vite@d428e7e)), closes [#17938](vitejs/vite#17938) - fix(deps): bump tsconfck ([#17990](vitejs/vite#17990)) ([8c661b2](vitejs/vite@8c661b2)), closes [#17990](vitejs/vite#17990) - fix(html): rewrite assets url in <template> ([#17988](vitejs/vite#17988)) ([413c86a](vitejs/vite@413c86a)), closes [#17988](vitejs/vite#17988) - fix(preload): add crossorigin attribute in CSS link tags ([#17930](vitejs/vite#17930)) ([15871c7](vitejs/vite@15871c7)), closes [#17930](vitejs/vite#17930) - chore: reduce diffs with v6 branch ([#17942](vitejs/vite#17942)) ([bf9065a](vitejs/vite@bf9065a)), closes [#17942](vitejs/vite#17942) - chore(deps): update all non-major dependencies ([#17945](vitejs/vite#17945)) ([cfb621e](vitejs/vite@cfb621e)), closes [#17945](vitejs/vite#17945) - chore(deps): update all non-major dependencies ([#17991](vitejs/vite#17991)) ([0ca53cf](vitejs/vite@0ca53cf)), closes [#17991](vitejs/vite#17991)
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Sep 20, 2024
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | vite | 5.4.2 | 5.4.6 | ## [v5.4.6](https://github.com/vitejs/vite/releases/tag/v5.4.6) Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v5.4.6/packages/vite/CHANGELOG.md) for details. ## [v5.4.5](https://github.com/vitejs/vite/releases/tag/v5.4.5) Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v5.4.5/packages/vite/CHANGELOG.md) for details. ## [v5.4.4](https://github.com/vitejs/vite/releases/tag/v5.4.4) Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v5.4.4/packages/vite/CHANGELOG.md) for details. ## [v5.4.3](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small543-2024-09-03-small) - fix: allow getting URL of JS files in publicDir ([#17915](vitejs/vite#17915)) ([943ece1](vitejs/vite@943ece1)), closes [#17915](vitejs/vite#17915) - fix: cjs warning respect the logLevel flag ([#17993](vitejs/vite#17993)) ([dc3c14f](vitejs/vite@dc3c14f)), closes [#17993](vitejs/vite#17993) - fix: improve CJS warning trace information ([#17926](vitejs/vite#17926)) ([5c5f82c](vitejs/vite@5c5f82c)), closes [#17926](vitejs/vite#17926) - fix: only remove entry assets handled by Vite core ([#17916](vitejs/vite#17916)) ([ebfaa7e](vitejs/vite@ebfaa7e)), closes [#17916](vitejs/vite#17916) - fix: waitForRequestIdle locked ([#17982](vitejs/vite#17982)) ([ad13760](vitejs/vite@ad13760)), closes [#17982](vitejs/vite#17982) - fix(css): fix directory index import in sass modern api ([#17960](vitejs/vite#17960)) ([9b001ba](vitejs/vite@9b001ba)), closes [#17960](vitejs/vite#17960) - fix(css): fix sass `file://` reference ([#17909](vitejs/vite#17909)) ([561b940](vitejs/vite@561b940)), closes [#17909](vitejs/vite#17909) - fix(css): fix sass modern source map ([#17938](vitejs/vite#17938)) ([d428e7e](vitejs/vite@d428e7e)), closes [#17938](vitejs/vite#17938) - fix(deps): bump tsconfck ([#17990](vitejs/vite#17990)) ([8c661b2](vitejs/vite@8c661b2)), closes [#17990](vitejs/vite#17990) - fix(html): rewrite assets url in <template> ([#17988](vitejs/vite#17988)) ([413c86a](vitejs/vite@413c86a)), closes [#17988](vitejs/vite#17988) - fix(preload): add crossorigin attribute in CSS link tags ([#17930](vitejs/vite#17930)) ([15871c7](vitejs/vite@15871c7)), closes [#17930](vitejs/vite#17930) - chore: reduce diffs with v6 branch ([#17942](vitejs/vite#17942)) ([bf9065a](vitejs/vite@bf9065a)), closes [#17942](vitejs/vite#17942) - chore(deps): update all non-major dependencies ([#17945](vitejs/vite#17945)) ([cfb621e](vitejs/vite@cfb621e)), closes [#17945](vitejs/vite#17945) - chore(deps): update all non-major dependencies ([#17991](vitejs/vite#17991)) ([0ca53cf](vitejs/vite@0ca53cf)), closes [#17991](vitejs/vite#17991)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New test case fails on legacy api withIt turned outsass-embeddedbut succeeds withsass. It looks like they way custom importer is called is different and potentially a bug on sass side.fixScssBugImportValuereturning both{ file, contents }confuses sass-embedded. This bug seems specific tosasspackage, so I skippedfixScssBugImportValue.