fix(css): fix sass `file://` reference #17909

hi-ogawa · 2024-08-21T02:55:42Z

Description

Closes feat(css): support sass compiler api and sass-embedded package #17754 (comment)

Sass modern API removes the support file: reference in sass/dart-sass#2077, so it needs to be implemented on Vite's custom importer.

stackblitz · 2024-08-21T02:55:44Z

Run & review this pull request in StackBlitz Codeflow.

bluwy

LGTM. Maybe when we implement file: support in the resolver this could be simplified too

packages/vite/src/node/plugins/css.ts

Co-authored-by: patak <583075+patak-dev@users.noreply.github.com>

| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | vite | 5.4.2 | 5.4.3 | ## [v5.4.3](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small543-2024-09-03-small) - fix: allow getting URL of JS files in publicDir ([#17915](vitejs/vite#17915)) ([943ece1](vitejs/vite@943ece1)), closes [#17915](vitejs/vite#17915) - fix: cjs warning respect the logLevel flag ([#17993](vitejs/vite#17993)) ([dc3c14f](vitejs/vite@dc3c14f)), closes [#17993](vitejs/vite#17993) - fix: improve CJS warning trace information ([#17926](vitejs/vite#17926)) ([5c5f82c](vitejs/vite@5c5f82c)), closes [#17926](vitejs/vite#17926) - fix: only remove entry assets handled by Vite core ([#17916](vitejs/vite#17916)) ([ebfaa7e](vitejs/vite@ebfaa7e)), closes [#17916](vitejs/vite#17916) - fix: waitForRequestIdle locked ([#17982](vitejs/vite#17982)) ([ad13760](vitejs/vite@ad13760)), closes [#17982](vitejs/vite#17982) - fix(css): fix directory index import in sass modern api ([#17960](vitejs/vite#17960)) ([9b001ba](vitejs/vite@9b001ba)), closes [#17960](vitejs/vite#17960) - fix(css): fix sass `file://` reference ([#17909](vitejs/vite#17909)) ([561b940](vitejs/vite@561b940)), closes [#17909](vitejs/vite#17909) - fix(css): fix sass modern source map ([#17938](vitejs/vite#17938)) ([d428e7e](vitejs/vite@d428e7e)), closes [#17938](vitejs/vite#17938) - fix(deps): bump tsconfck ([#17990](vitejs/vite#17990)) ([8c661b2](vitejs/vite@8c661b2)), closes [#17990](vitejs/vite#17990) - fix(html): rewrite assets url in <template> ([#17988](vitejs/vite#17988)) ([413c86a](vitejs/vite@413c86a)), closes [#17988](vitejs/vite#17988) - fix(preload): add crossorigin attribute in CSS link tags ([#17930](vitejs/vite#17930)) ([15871c7](vitejs/vite@15871c7)), closes [#17930](vitejs/vite#17930) - chore: reduce diffs with v6 branch ([#17942](vitejs/vite#17942)) ([bf9065a](vitejs/vite@bf9065a)), closes [#17942](vitejs/vite#17942) - chore(deps): update all non-major dependencies ([#17945](vitejs/vite#17945)) ([cfb621e](vitejs/vite@cfb621e)), closes [#17945](vitejs/vite#17945) - chore(deps): update all non-major dependencies ([#17991](vitejs/vite#17991)) ([0ca53cf](vitejs/vite@0ca53cf)), closes [#17991](vitejs/vite#17991)

| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | vite | 5.4.2 | 5.4.4 | ## [v5.4.4](https://github.com/vitejs/vite/releases/tag/v5.4.4) Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v5.4.4/packages/vite/CHANGELOG.md) for details. ## [v5.4.3](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small543-2024-09-03-small) - fix: allow getting URL of JS files in publicDir ([#17915](vitejs/vite#17915)) ([943ece1](vitejs/vite@943ece1)), closes [#17915](vitejs/vite#17915) - fix: cjs warning respect the logLevel flag ([#17993](vitejs/vite#17993)) ([dc3c14f](vitejs/vite@dc3c14f)), closes [#17993](vitejs/vite#17993) - fix: improve CJS warning trace information ([#17926](vitejs/vite#17926)) ([5c5f82c](vitejs/vite@5c5f82c)), closes [#17926](vitejs/vite#17926) - fix: only remove entry assets handled by Vite core ([#17916](vitejs/vite#17916)) ([ebfaa7e](vitejs/vite@ebfaa7e)), closes [#17916](vitejs/vite#17916) - fix: waitForRequestIdle locked ([#17982](vitejs/vite#17982)) ([ad13760](vitejs/vite@ad13760)), closes [#17982](vitejs/vite#17982) - fix(css): fix directory index import in sass modern api ([#17960](vitejs/vite#17960)) ([9b001ba](vitejs/vite@9b001ba)), closes [#17960](vitejs/vite#17960) - fix(css): fix sass `file://` reference ([#17909](vitejs/vite#17909)) ([561b940](vitejs/vite@561b940)), closes [#17909](vitejs/vite#17909) - fix(css): fix sass modern source map ([#17938](vitejs/vite#17938)) ([d428e7e](vitejs/vite@d428e7e)), closes [#17938](vitejs/vite#17938) - fix(deps): bump tsconfck ([#17990](vitejs/vite#17990)) ([8c661b2](vitejs/vite@8c661b2)), closes [#17990](vitejs/vite#17990) - fix(html): rewrite assets url in <template> ([#17988](vitejs/vite#17988)) ([413c86a](vitejs/vite@413c86a)), closes [#17988](vitejs/vite#17988) - fix(preload): add crossorigin attribute in CSS link tags ([#17930](vitejs/vite#17930)) ([15871c7](vitejs/vite@15871c7)), closes [#17930](vitejs/vite#17930) - chore: reduce diffs with v6 branch ([#17942](vitejs/vite#17942)) ([bf9065a](vitejs/vite@bf9065a)), closes [#17942](vitejs/vite#17942) - chore(deps): update all non-major dependencies ([#17945](vitejs/vite#17945)) ([cfb621e](vitejs/vite@cfb621e)), closes [#17945](vitejs/vite#17945) - chore(deps): update all non-major dependencies ([#17991](vitejs/vite#17991)) ([0ca53cf](vitejs/vite@0ca53cf)), closes [#17991](vitejs/vite#17991)

| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | vite | 5.4.2 | 5.4.5 | ## [v5.4.5](https://github.com/vitejs/vite/releases/tag/v5.4.5) Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v5.4.5/packages/vite/CHANGELOG.md) for details. ## [v5.4.4](https://github.com/vitejs/vite/releases/tag/v5.4.4) Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v5.4.4/packages/vite/CHANGELOG.md) for details. ## [v5.4.3](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small543-2024-09-03-small) - fix: allow getting URL of JS files in publicDir ([#17915](vitejs/vite#17915)) ([943ece1](vitejs/vite@943ece1)), closes [#17915](vitejs/vite#17915) - fix: cjs warning respect the logLevel flag ([#17993](vitejs/vite#17993)) ([dc3c14f](vitejs/vite@dc3c14f)), closes [#17993](vitejs/vite#17993) - fix: improve CJS warning trace information ([#17926](vitejs/vite#17926)) ([5c5f82c](vitejs/vite@5c5f82c)), closes [#17926](vitejs/vite#17926) - fix: only remove entry assets handled by Vite core ([#17916](vitejs/vite#17916)) ([ebfaa7e](vitejs/vite@ebfaa7e)), closes [#17916](vitejs/vite#17916) - fix: waitForRequestIdle locked ([#17982](vitejs/vite#17982)) ([ad13760](vitejs/vite@ad13760)), closes [#17982](vitejs/vite#17982) - fix(css): fix directory index import in sass modern api ([#17960](vitejs/vite#17960)) ([9b001ba](vitejs/vite@9b001ba)), closes [#17960](vitejs/vite#17960) - fix(css): fix sass `file://` reference ([#17909](vitejs/vite#17909)) ([561b940](vitejs/vite@561b940)), closes [#17909](vitejs/vite#17909) - fix(css): fix sass modern source map ([#17938](vitejs/vite#17938)) ([d428e7e](vitejs/vite@d428e7e)), closes [#17938](vitejs/vite#17938) - fix(deps): bump tsconfck ([#17990](vitejs/vite#17990)) ([8c661b2](vitejs/vite@8c661b2)), closes [#17990](vitejs/vite#17990) - fix(html): rewrite assets url in <template> ([#17988](vitejs/vite#17988)) ([413c86a](vitejs/vite@413c86a)), closes [#17988](vitejs/vite#17988) - fix(preload): add crossorigin attribute in CSS link tags ([#17930](vitejs/vite#17930)) ([15871c7](vitejs/vite@15871c7)), closes [#17930](vitejs/vite#17930) - chore: reduce diffs with v6 branch ([#17942](vitejs/vite#17942)) ([bf9065a](vitejs/vite@bf9065a)), closes [#17942](vitejs/vite#17942) - chore(deps): update all non-major dependencies ([#17945](vitejs/vite#17945)) ([cfb621e](vitejs/vite@cfb621e)), closes [#17945](vitejs/vite#17945) - chore(deps): update all non-major dependencies ([#17991](vitejs/vite#17991)) ([0ca53cf](vitejs/vite@0ca53cf)), closes [#17991](vitejs/vite#17991)

| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | vite | 5.4.2 | 5.4.6 | ## [v5.4.6](https://github.com/vitejs/vite/releases/tag/v5.4.6) Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v5.4.6/packages/vite/CHANGELOG.md) for details. ## [v5.4.5](https://github.com/vitejs/vite/releases/tag/v5.4.5) Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v5.4.5/packages/vite/CHANGELOG.md) for details. ## [v5.4.4](https://github.com/vitejs/vite/releases/tag/v5.4.4) Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v5.4.4/packages/vite/CHANGELOG.md) for details. ## [v5.4.3](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small543-2024-09-03-small) - fix: allow getting URL of JS files in publicDir ([#17915](vitejs/vite#17915)) ([943ece1](vitejs/vite@943ece1)), closes [#17915](vitejs/vite#17915) - fix: cjs warning respect the logLevel flag ([#17993](vitejs/vite#17993)) ([dc3c14f](vitejs/vite@dc3c14f)), closes [#17993](vitejs/vite#17993) - fix: improve CJS warning trace information ([#17926](vitejs/vite#17926)) ([5c5f82c](vitejs/vite@5c5f82c)), closes [#17926](vitejs/vite#17926) - fix: only remove entry assets handled by Vite core ([#17916](vitejs/vite#17916)) ([ebfaa7e](vitejs/vite@ebfaa7e)), closes [#17916](vitejs/vite#17916) - fix: waitForRequestIdle locked ([#17982](vitejs/vite#17982)) ([ad13760](vitejs/vite@ad13760)), closes [#17982](vitejs/vite#17982) - fix(css): fix directory index import in sass modern api ([#17960](vitejs/vite#17960)) ([9b001ba](vitejs/vite@9b001ba)), closes [#17960](vitejs/vite#17960) - fix(css): fix sass `file://` reference ([#17909](vitejs/vite#17909)) ([561b940](vitejs/vite@561b940)), closes [#17909](vitejs/vite#17909) - fix(css): fix sass modern source map ([#17938](vitejs/vite#17938)) ([d428e7e](vitejs/vite@d428e7e)), closes [#17938](vitejs/vite#17938) - fix(deps): bump tsconfck ([#17990](vitejs/vite#17990)) ([8c661b2](vitejs/vite@8c661b2)), closes [#17990](vitejs/vite#17990) - fix(html): rewrite assets url in <template> ([#17988](vitejs/vite#17988)) ([413c86a](vitejs/vite@413c86a)), closes [#17988](vitejs/vite#17988) - fix(preload): add crossorigin attribute in CSS link tags ([#17930](vitejs/vite#17930)) ([15871c7](vitejs/vite@15871c7)), closes [#17930](vitejs/vite#17930) - chore: reduce diffs with v6 branch ([#17942](vitejs/vite#17942)) ([bf9065a](vitejs/vite@bf9065a)), closes [#17942](vitejs/vite#17942) - chore(deps): update all non-major dependencies ([#17945](vitejs/vite#17945)) ([cfb621e](vitejs/vite@cfb621e)), closes [#17945](vitejs/vite#17945) - chore(deps): update all non-major dependencies ([#17991](vitejs/vite#17991)) ([0ca53cf](vitejs/vite@0ca53cf)), closes [#17991](vitejs/vite#17991)

hi-ogawa added 2 commits August 21, 2024 11:47

fix(css): fix sass file: reference

ccaa6c8

refactor: handle file: in resolver

57bcf5c

chore: lint

e4babed

hi-ogawa marked this pull request as ready for review August 21, 2024 03:05

bluwy previously approved these changes Aug 21, 2024

View reviewed changes

patak-dev reviewed Aug 21, 2024

View reviewed changes

packages/vite/src/node/plugins/css.ts Outdated Show resolved Hide resolved

fix: check file:// not file:

67d0bb4

Co-authored-by: patak <583075+patak-dev@users.noreply.github.com>

hi-ogawa dismissed bluwy’s stale review via 67d0bb4 August 21, 2024 10:14

This comment was marked as outdated.

Sign in to view

hi-ogawa changed the title ~~fix(css): fix sass file: reference~~ fix(css): fix sass file:// reference Aug 21, 2024

bluwy approved these changes Aug 22, 2024

View reviewed changes

bluwy merged commit 561b940 into vitejs:main Aug 22, 2024
13 checks passed

hi-ogawa deleted the fix-sass-file-reference branch August 22, 2024 09:42

This was referenced Aug 28, 2024

sass directory index import fails in some cases after #17909 #17959

Closed

fix(css): fix directory index import in sass modern api #17960

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(css): fix sass `file://` reference #17909

fix(css): fix sass `file://` reference #17909

hi-ogawa commented Aug 21, 2024

stackblitz bot commented Aug 21, 2024

bluwy left a comment

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

fix(css): fix sass file:// reference #17909

fix(css): fix sass file:// reference #17909

Conversation

hi-ogawa commented Aug 21, 2024

Description

stackblitz bot commented Aug 21, 2024

bluwy left a comment

Choose a reason for hiding this comment

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

fix(css): fix sass `file://` reference #17909

fix(css): fix sass `file://` reference #17909