Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(create-app): add type="button" to satisfy eslint rule #3685

Merged
merged 1 commit into from
Jun 6, 2021

Conversation

TeXmeijin
Copy link
Contributor

@TeXmeijin TeXmeijin commented Jun 6, 2021

@see https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/button-has-type.md

Description

Some of create-app template has <button> element that has not 'type' attribute.

So, following eslint rules will show errors.

So I added type="button" to <button> element.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 requested a review from aleclarson June 6, 2021 09:57
@aleclarson aleclarson changed the title [create vite-app] refactor: add type="button" for a11y and an eslint rule. chore(create-app): add type="button" to satisfy eslint rule Jun 6, 2021
@aleclarson aleclarson merged commit 32c596c into vitejs:main Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants