Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(create-app): add type="button" to satisfy eslint rule #3685

Merged
merged 1 commit into from
Jun 6, 2021
Merged

chore(create-app): add type="button" to satisfy eslint rule #3685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/create-app/template-react-ts/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ function App() {
<img src={logo} className="App-logo" alt="logo" />
<p>Hello Vite + React!</p>
<p>
<button onClick={() => setCount((count) => count + 1)}>
<button type="button" onClick={() => setCount((count) => count + 1)}>
count is: {count}
</button>
</p>
Expand Down
2 changes: 1 addition & 1 deletion packages/create-app/template-react/src/App.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ function App() {
<img src={logo} className="App-logo" alt="logo" />
<p>Hello Vite + React!</p>
<p>
<button onClick={() => setCount((count) => count + 1)}>
<button type="button" onClick={() => setCount((count) => count + 1)}>
count is: {count}
</button>
</p>
Expand Down
2 changes: 1 addition & 1 deletion packages/create-app/template-vue-ts/src/components/HelloWorld.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<a href="https://v3.vuejs.org/" target="_blank">Vue 3 Docs</a>
</p>

<button @click="count++">count is: {{ count }}</button>
<button type="button" @click="count++">count is: {{ count }}</button>
<p>
Edit
<code>components/HelloWorld.vue</code> to test hot module replacement.
Expand Down
2 changes: 1 addition & 1 deletion packages/create-app/template-vue/src/components/HelloWorld.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<a href="https://v3.vuejs.org/" target="_blank">Vue 3 Documentation</a>
</p>

<button @click="state.count++">count is: {{ state.count }}</button>
<button type="button" @click="state.count++">count is: {{ state.count }}</button>
<p>
Edit
<code>components/HelloWorld.vue</code> to test hot module replacement.
Expand Down