Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change location of server start log messages #5016

Merged
merged 1 commit into from
Sep 25, 2021

Conversation

benmccann
Copy link
Collaborator

Description

Print the server startup messages in the CLI rather than the methods which start the server

Additional context

SvelteKit has started calling createServer to start the Vite server. However, this has created some log messages that duplicate / conflict with SvelteKit's. Moving these log messages will allow Vite to function exactly as it does today while fixing the log messages for SvelteKit


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 self-requested a review September 23, 2021 15:25
@yyx990803
Copy link
Member

FYI this causes the URLs to no longer print for other projects that uses createServer() (e.g. VitePress).

I exposed the print utility in f94a720 and 96a9ee4.

@lubomirblazekcz
Copy link
Contributor

Is this documented somewhere? I've also used createServer() on my projects, but I kind of miss the old fancy info now, including version etc.

I've manage to use server.printUrls(), but that only returns the urls. Is there a way to let it print like before? Including vite version etc.?

aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants