Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert change location of server start log messages #5016 #5140

Closed
wants to merge 1 commit into from

Conversation

patak-dev
Copy link
Member

@patak-dev patak-dev commented Sep 29, 2021

Description

Revert #5016

@bluwy reported in Vite Land that #5016 caused logs to be reorder in some cases

vite v2.6.0 dev server running at:

Pre-bundling dependencies:
  immer
  svelte/store
  @fortawesome/free-solid-svg-icons
  svelte/transition
  svelte/animate
  (...and 10 more)
(this will be run only when your dependencies or config have changed)
  > Local: http://localhost:3000/
  > Network: use `--host` to expose

  ready in 1477ms.

This PR reverts this change, @benmccann was proposing other options to avoid the messages inside server.listen(). We can discuss them in other PRs.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@patak-dev
Copy link
Member Author

Fixed in #5141

@patak-dev patak-dev closed this Sep 29, 2021
@patak-dev patak-dev deleted the revert-logs-change branch September 30, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant