Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralised dependency list #4780

Closed
guidoiaquinti opened this issue Apr 2, 2019 · 2 comments
Closed

Centralised dependency list #4780

guidoiaquinti opened this issue Apr 2, 2019 · 2 comments
Labels
Type: Enhancement Logical improvement (somewhere between a bug and feature)

Comments

@guidoiaquinti
Copy link
Member

Overview of the Issue

In the codebase there are several places where we manage external dependencies. Unfortunately it's hard to keep them in sync and de-sync can often create issues.

Example:

I'm opening this issue to keep track of the problem and with the hope of discussing a proposal for a single source of truth for all the dependencies needed to build and run Vitess.

@morgo morgo added the Type: Enhancement Logical improvement (somewhere between a bug and feature) label Oct 26, 2019
@morgo
Copy link
Contributor

morgo commented Oct 26, 2019

The dependency list should be shrinking a lot (use of go modules, converting Python tests to go etc.), which will make it easier to manage.

I will look at updating the build guide in a couple of months time as this work completes. We can then take another look at this issue.

@morgo
Copy link
Contributor

morgo commented Dec 7, 2019

I have been updating the build guides as we trim dependencies. See vitessio/website#372 for a next-generation, where they are quite light.

I also added a dependency_check shell script to the Makefile in #5527

I am going to close this issue now, but please feel free to re-open if you feel this is not sufficiently addressed.

@morgo morgo closed this as completed Dec 7, 2019
systay pushed a commit that referenced this issue Jul 22, 2024
…w files (#4780)

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Co-authored-by: Rohit Nayak <rohit@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

No branches or pull requests

2 participants