Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although provisioning succeeds, the Vagrant box fails to build Vitess on first
vagrant ssh
. It aborts on a missing Java compiler when trying to build Zookeeper, thus missing plenty of dependencies:Note the
JAVA_HOME
.Furthermore, although
bootstrap.sh
aborts,build.sh
still continues. This makes the process end with a misleading error on Go dependencies:This PR changes
openjdk-7-jdk
toopenjdk-8-jdk
, that is now available for the Ubuntu version (see here), matching the version used for Docker. (An example for #4780.) It also makes the build script abort on errors, just likebootstrap.sh
does. This seems to make #4883 obsolete.