Insert ignore for vindexes without autocommit appear incorrect.

[mpawliszyn]

I created a test that proves this.
mpawliszyn@8202a11

[sougou]

Same as this? https://github.com/vitessio/vitess/blob/master/go/vt/vtgate/endtoend/lookup_test.go#L223

[mpawliszyn]

No that one uses an autocommit vindex so it works. I'm pretty sure the problem is that the insert ignore verify only works when the insert into the vindex has been committed. I suspect we aren't sending the right transaction id during that verify

[sougou]

Ahh. I see. Looks like I tested the wrong table. Let me try this one out.

[sougou]

Ok. I believe the test for t2 is still legit, and it would have failed without the ordering fix in that PR.
However, insert ignore does not work for consistent lookups. This is a different bug in the consistent lookup itself?

[mpawliszyn]

Yes t2 is absolutely legit and it fixes the problem we were having. We only use autocommit vindexes. I just found this bug while I was working on this so I wanted to track it somewhere.

Note that if you try the insert ignore twice it works because in the first call the vindex is inserted so when the second call is made the verify works.

[sougou]

Yeah. I found the problem. The fix may be tricky because Verify is used from two different code paths (one for owned, the other unowned), and may have to use different commit order directives. I have to think of a way to do this without changing the Vindex API.

[mpawliszyn]

We are in no rush for a fix for this. I'm glad you found the problem so quickly though.

…

On Tue, Jul 2, 2019 at 1:00 PM Sugu Sougoumarane ***@***.***> wrote: Yeah. I found the problem. The fix may be tricky because Verify is used from two different code paths (one of owne, the other unowned), and may have to use different commit order directives. I have to think of a way to do this without changing the Vindex API. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4974?email_source=notifications&email_token=AAZFSMORSQN4CSRKTJ2HHELP5OCUNA5CNFSM4H45D252YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZB5PPA#issuecomment-507762620>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAZFSMLJ6SBHLXGDZYSJH7LP5OCUNANCNFSM4H45D25Q> .