consistent lookup: handle insert ignore #4978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes vitessio#4974 Insert ignore wasn't working correctly because the verify was using the normal transaction instead of the 'pre' transaction where the rows were actually created. This implementation changes the consistent lookup's Verify function to also use the 'pre' transaction always. There is another code path that gets used if the vindex is unowned. That will also cause a 'pre' transaction to be created. Without this change, the transaction would have been a normal one. This mildly affects the commit order, but there should be no material difference. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
|
@mpawliszyn Ping. |
|
@mpawliszyn ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4974
Insert ignore wasn't working correctly because the verify was using
the normal transaction instead of the 'pre' transaction where the
rows were actually created.
This implementation changes the consistent lookup's Verify function
to also use the 'pre' transaction always.
There is another code path that gets used if the vindex is unowned.
That will also cause a 'pre' transaction to be created. Without this
change, the transaction would have been a normal one. This mildly
affects the commit order, but there should be no material difference.
Signed-off-by: Sugu Sougoumarane ssougou@gmail.com