This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Slack sync upstream 2019 12 11.r0 #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by github workflow Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com>
Signed-off-by: Harshit Gangal <harshit.gangal@gmail.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Make the booststrap.sh install correct chromedriver for aarch64 Change-Id: Iefa98ed7918725f00fb8db131cae12383c44c42e Signed-off-by: Jiamei.Xie <Jiamei.Xie@arm.com>
Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com>
Fix chromedriver dependency issue for aarch64.
Signed-off-by: Morgan Tocker <tocker@gmail.com>
java: Bump SNAPSHOT version to 4.1-SNAPSHOT after Vitess release 4.0
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
While working on filePos flavor, I encountered this issue where an "other" statement will cause the next GTID to not be immediately sent. This can cause delays if the target waits for that event. This is pretty rare for GTID mode. But will likely be more pronounced for filePos. So, I'm proactively making this fix to make sure we don't delay sending of GTIDs, even in the case of non-relevant events. Because of this change, this also means that we don't have to generate pseudo-gtids. Generating GTIDs outside of transactions, coupled with OTHER event will make the right thing happen. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
usage compare to one copy per mysql connect previously Signed-off-by: Yun Lai <ylai@squareup.com>
vrepl: handle "other" events
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Add Flavor as a conn param. Add code to handle flavor-specific GTID. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
In this scheme, the filePos reader detects whether we are in a transaction or not, and emits appropriate GTID events. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
The vstreamer sent GTIDs "as they came". With the new change, GTIDs are sent only when they matter: on COMMIT, DDL or OTHER. This new approach makes the protocol easier to understand. Also, it makes it easier for filePos to continuously send file and position. The correct values will get used when significant events like COMMIT are encountered. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Maxim Krasilnikov <mak.krasilnikov@gmail.com> Signed-off-by: Maxim Krasilnikov <m.krasilnikov@space307.com>
The vplayer currently uses ambiguous rules about how it handles the case where a stop position was exceeded. As part of this change, we'll standardize on: A stop position is considered to be successfully reached if the new position is greater than or equal to the specified position. The main motivation for this change is that the possibility of position mismatch is higher in the case of file:pos tracking. We're likely to hit many false positives if we're too strict. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: lokune <laban.okune@ma3route.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
etcd on unstable or unsupported architectures will print a warning message and immediately exit if the environment variable ETCD_UNSUPPORTED_ARCH is not set to the target architecture. Change-Id: Ifdd3ed4ae322484477d2db3e2d0eed09e086518f Signed-off-by: Jiamei.Xie <Jiamei.Xie@arm.com>
Signed-off-by: yuxiaobo <yuxiaobogo@163.com>
Eliminate that it isn't transient state causing it to fail. Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
* converted vtctld_test.py to go Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com> Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com>
* migrated one of testcase from schema.py to schema_test.go Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com> Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com>
* converted tabletmanager test cases to go Signed-off-by: Ajeet jain <ajeet@planetscale.com> Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com>
* ported testcase of keyspace_test.py Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com> Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com>
* Converted sharded test from py to go Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com> Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com>
Signed-off-by: saurabh <saurabh.408@gmail.com> Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com>
Signed-off-by: saurabh <saurabh.408@gmail.com> Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com>
Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com>
TabletManager remaining test cases in GO Signed-off-by: Ajeet jain <ajeet@planetscale.com> Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com>
* moved sql start to non-blocking mode Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com> Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com> * readme for go endtoend test cases Signed-off-by: Ajeet jain <ajeet@planetscale.com> * Update README.md Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com>
Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com>
EndtoEnd test cases in Go migrated from Python
Flatten/Merge VTTOP and VTROOT variables
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Minor spelling/grammar improvements Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Fixes vitessio#5421 Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
This allows bootstrap to eventually be deprecated. Signed-off-by: Morgan Tocker <tocker@gmail.com>
…kging Make packages with cut down binaries list
Add golangci-lint with linters disabled
…dency-chk Add better dependency checking
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
guidoiaquinti
approved these changes
Dec 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vitess continues to move fast! More than 300 commits since our last sync a month ago. Luckily many of them are general improvements in the code base. Only a few that I marked as risky.
Risky Changes
-Make semi sync extension optional vitessio/vitess#5483: Make semi sync extension optional
Slack changes
Other Changes
Docs / Tooling / Tests