Load tls certificate and x509 cert pool once per file to reduce memory usage #5423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyonlai
force-pushed
the
ylai/2019-11-11/one-copy-of-tls-certificate-per-file
branch
from
e2352a4
to
dcfd276
Compare
systay
approved these changes
Nov 11, 2019
lyonlai
force-pushed
the
ylai/2019-11-11/one-copy-of-tls-certificate-per-file
branch
from
dcfd276
to
3b78aef
Compare
dkhenry
suggested changes
Nov 11, 2019
lyonlai
force-pushed
the
ylai/2019-11-11/one-copy-of-tls-certificate-per-file
branch
from
3b78aef
to
ee81517
Compare
usage compare to one copy per mysql connect previously Signed-off-by: Yun Lai <ylai@squareup.com>
lyonlai
force-pushed
the
ylai/2019-11-11/one-copy-of-tls-certificate-per-file
branch
from
ee81517
to
6888606
Compare
|
@dkhenry Is there any other changes besides the |
|
No changes, just delayed in getting back to this |
dkhenry
approved these changes
Nov 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment when starting connections to mysql database it's creating multiple copies of tls certificates for the same pem file loaded, which is causing memory pressure when loading a big combo certificate (example the combo certificate offered by AWS RDS).
This PR address the issue by creating only one copy of loaded certificate per file and refer to it, which brings down the memory usage for tls connections. The image below shows the after(left) vs before(right) comparison via golang's pprof's web interface.