Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shellcheck hook to handle multiple modified scripts in single commit #5453

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Fix shellcheck hook to handle multiple modified scripts in single commit #5453

merged 1 commit into from
Nov 25, 2019

Conversation

0verbyte
Copy link
Contributor

Fixes: #5305

This works for my shellcheck version (0.7.0)

@sougou sougou requested a review from morgo November 23, 2019 20:18
@sougou
Copy link
Contributor

sougou commented Nov 23, 2019

Need to fix DCO. You have amend your commit with git commit -s.

Fixes: #5305
Signed-off-by: Brandon Davis <dbrandon.91@gmail.com>
Copy link
Contributor

@morgo morgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working on this!

@morgo morgo merged commit 387c1dc into vitessio:master Nov 25, 2019
@0verbyte 0verbyte deleted the fix-shellcheck-precommit branch November 26, 2019 02:41
systay pushed a commit that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shellcheck pre-commit hook is broken
3 participants