Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap.sh: add back etdctl symlink #5495

Merged
merged 2 commits into from
Dec 3, 2019
Merged

bootstrap.sh: add back etdctl symlink #5495

merged 2 commits into from
Dec 3, 2019

Conversation

gedgar
Copy link
Contributor

@gedgar gedgar commented Dec 3, 2019

If bootstrap.sh installs etcd, the local tutorial can encounter this error:

./etcd-up.sh: line 35: etcdctl: command not found
./etcd-up.sh: line 39: etcdctl: command not found

This adds back the symlink added in ee6a939

Signed-off-by: Gary Edgar gary@planetscale.com

@gedgar
bootstrap.sh: add back etdctl symlink
f9c02d5 
Signed-off-by: Gary Edgar <gary@planetscale.com>
@gedgar gedgar requested a review from sougou as a code owner December 3, 2019 16:25
@morgo morgo self-requested a review December 3, 2019 16:28
morgo
morgo approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@morgo morgo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit: change amd64 to target, so it will work with aarch64 too.

@gedgar
bootstrap.sh: remove amd64 hardcoding
dc4ef6f 
Signed-off-by: Gary Edgar <gary@planetscale.com>
@morgo morgo merged commit cfc7335 into vitessio:master Dec 3, 2019
@morgo morgo deleted the etcdctl-symlink-fix branch December 3, 2019 17:22
@rafael rafael mentioned this pull request Dec 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgo morgo morgo approved these changes

@sougou sougou Awaiting requested review from sougou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gedgar @morgo