vrepl: handle "other" events #5429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on filePos flavor, I encountered this issue where an "other" statement will cause the next GTID to not be immediately sent. This can cause delays if the target waits for that event. This is pretty rare for GTID mode. But will likely be more pronounced for filePos. So, I'm proactively making this fix to make sure we don't delay sending of GTIDs, even in the case of non-relevant events. Because of this change, this also means that we don't have to generate pseudo-gtids. Generating GTIDs outside of transactions, coupled with OTHER event will make the right thing happen. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
|
This also LGTM to me. Could you unpack this more?
I did not get that part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on filePos flavor, I encountered this issue where
an "other" statement will cause the next GTID to not be immediately
sent. This can cause delays if the target waits for that event.
This is pretty rare for GTID mode. But will likely be more pronounced
for filePos. So, I'm proactively making this fix to make sure we
don't delay sending of GTIDs, even in the case of non-relevant events.
Because of this change, this also means that we don't have to generate
pseudo-gtids. Generating GTIDs outside of transactions, coupled with
OTHER event will make the right thing happen.
Signed-off-by: Sugu Sougoumarane ssougou@gmail.com