Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vtctl] ChangeTabletType should use RemoteOperationTimeout to fail fast(er) on unreachable tablets #8051

Closed
ajm188 opened this issue May 6, 2021 · 0 comments · Fixed by #8052
Closed

[vtctl] ChangeTabletType should use RemoteOperationTimeout to fail fast(er) on unreachable tablets #8051

ajm188 opened this issue May 6, 2021 · 0 comments · Fixed by #8052
Labels
Component: Cluster management Type: Enhancement Logical improvement (somewhere between a bug and feature)

Comments

@ajm188
Copy link
Contributor

ajm188 commented May 6, 2021

Feature Description

What the title says. When doing a ChangeTabletType vtctl command, we should use the minimum of -action_timeout and *topo.RemoteOperationTimeout to bound the rpc call, to fail fast if either the topo or the actual tablet is unreachable.
@ajm188 ajm188 added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Cluster management labels May 6, 2021
ajm188 added a commit to tinyspeck/vitess that referenced this issue May 6, 2021
@ajm188
Add RemoteOperationTimeout to both legacy and grpc ChangeTabletType…
5bd5498 
… implementations

Closes vitessio#8051.

Signed-off-by: Andrew Mason <amason@slack-corp.com>
@ajm188 ajm188 mentioned this issue May 6, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Cluster management Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
1 participant
@ajm188