Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RemoteOperationTimeout to both legacy and grpc ChangeTabletType implementations. #8052

Merged

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented May 6, 2021

Signed-off-by: Andrew Mason amason@slack-corp.com

Description

Related Issue(s)

Closes #8051.

Checklist

  • Tests were added or are not required: n/a
  • Documentation was added or is not required: n/a

Deployment Notes

… implementations

Closes vitessio#8051.

Signed-off-by: Andrew Mason <amason@slack-corp.com>
@ajm188 ajm188 requested review from rafael and deepthi May 6, 2021 03:07
@ajm188 ajm188 requested a review from doeg as a code owner May 6, 2021 03:07
Copy link
Member

@rafael rafael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafael rafael merged commit 0a5e76b into vitessio:master May 7, 2021
@rafael rafael deleted the am_change_tablet_type_remote_timeout branch May 7, 2021 00:48
@ajm188 ajm188 added Component: Cluster management Type: Enhancement Logical improvement (somewhere between a bug and feature) labels May 23, 2021
ajm188 pushed a commit to tinyspeck/vitess that referenced this pull request Jul 23, 2021
…_remote_timeout

Add RemoteOperationTimeout to both legacy and grpc `ChangeTabletType` implementations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Cluster management Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vtctl] ChangeTabletType should use RemoteOperationTimeout to fail fast(er) on unreachable tablets
2 participants