-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: transaction_isolation to be applied at session level #12281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
GuptaManan100
approved these changes
Feb 9, 2023
frouioui
approved these changes
Feb 9, 2023
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
I was unable to backport this Pull Request to the following branches: |
harshit-gangal
added a commit
to planetscale/vitess
that referenced
this pull request
Feb 10, 2023
…2281) Signed-off-by: Harshit Gangal <harshit@planetscale.com>
3 tasks
frouioui
pushed a commit
that referenced
this pull request
Feb 13, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR #11987 that added support for
transaction_isolation
works as expected with the settings pool, but without it, the transaction_isolation level was applied on the next transaction by usingset @@transaction_isolation
instead it should be applied withset transaction_isolation
so that it is applied at the session level. This only happens in the case when any shard session was already open.go/vt/vtgate/engine/set.go
This PR fixes it.
Related Issue(s)
Checklist
Deployment Notes