Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transaction_isolation to be applied at session level #12281

Merged
merged 2 commits into from
Feb 9, 2023

Conversation

harshit-gangal
Copy link
Member

Description

The PR #11987 that added support for transaction_isolation works as expected with the settings pool, but without it, the transaction_isolation level was applied on the next transaction by using set @@transaction_isolation instead it should be applied with set transaction_isolation so that it is applied at the session level. This only happens in the case when any shard session was already open.

go/vt/vtgate/engine/set.go

	// Update existing shard session with new system variable settings.
	rss := vcursor.Session().ShardSession()
        ...
	for i := 0; i < len(rss); i++ {
                ...
		fmt.Sprintf("set @@%s = %s", svs.Name, svs.Expr)
	}
        ...

This PR fixes it.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported 16.0
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 8, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@harshit-gangal harshit-gangal removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 8, 2023
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal merged commit d208d36 into vitessio:main Feb 9, 2023
@harshit-gangal harshit-gangal deleted the set-tx-fix branch February 9, 2023 15:33
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 9, 2023

I was unable to backport this Pull Request to the following branches: release-16.0.

harshit-gangal added a commit to planetscale/vitess that referenced this pull request Feb 10, 2023
…2281)

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
frouioui pushed a commit that referenced this pull request Feb 13, 2023
…12308)

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants