Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oops #15542

Closed
wants to merge 236 commits into from
Closed

oops #15542

wants to merge 236 commits into from

Conversation

hmaurer
Copy link

@hmaurer hmaurer commented Mar 21, 2024 •
edited
Loading

No description provided.

GuptaManan100 and others added 30 commits February 3, 2023 21:57
@GuptaManan100
Code freeze of release-16.0 (vitessio#12232)
27e04c1 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@frouioui
Revert default MySQL 80 version to 8.0.30 (vitessio#12252) (vitessi…
e8c258d 
…o#12273)

* Revert default MySQL 80 version



* upgrade mysql80 default to 8.0.30



* Add release notes regarding MySQL upgrade path in the vitess-operator



* Remove unwanted upgrade path step



---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@GuptaManan100
Release of v16.0.0-rc1 (vitessio#12235)
5334b22 
* Release notes for 16.0.0-rc1

Signed-off-by: Manan Gupta <manan@planetscale.com>

* Release commit for 16.0.0-rc1

Signed-off-by: Manan Gupta <manan@planetscale.com>

---------

Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
feat: fix release notes (vitessio#12276)
4e32ce1 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
Back to dev mode (vitessio#12277)
51a7abf 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@frouioui
Download mariadb from vitess-resources (vitessio#12271) (vitessio#12279)
8c57874 
* Download mariadb from vitess-resources



* Use proper mariadb version increment in tests



* Use 10.10.3 instead of LTS



---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@GuptaManan100
feat: fix summary and release notes (vitessio#12283)
ae796b2 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@vitess-bot @GuptaManan100
feat: fix release script (vitessio#12289)
236c147 
Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>
@vitess-bot @harshit-gangal
[release-16.0] Fix aggregation on outer joins (vitessio#12298) (vites…
8d77ddf 
…sio#12311)

* fix: aggregation coming from right hand side of left join check for null

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* test: added a sum test

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* addressed review comments

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

---------

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Co-authored-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
fix: transaction_isolation to be applied at session level (vitessio#1…
85e505d 
…2281) (vitessio#12308)

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@vitess-bot @harshit-gangal
fix: added null safe operator precendence rule (vitessio#12307)
cdae7f0 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Co-authored-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
add database name to _vt.views table (vitessio#12368)
dc92d01 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@mattlord
Examples: Add lib functions to wait for shard states (vitessio#12239) (…
9b6a4c5 
…vitessio#12278)

* Add lib functions to wait for shard states



* Fixup region example too



* Address minor review comments



* Remove extraneous line change



* Refactor to remove duplicated files/code

Also address shellcheck warnings.



* Fix tests that run in CI



* Use more robust location detection



* Fix backup tests



* Exit on shard healthy failure



* Remove unused dups and adjust client_test and Dockerfiles



---------

Signed-off-by: Matt Lord <mattalord@gmail.com>
@systay
Fix for USING when column names not lower cased (vitessio#12379)
49ae2a9 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@vitess-bot @systay
Fix bug in vtexplain around JOINs (vitessio#12384)
29e137a 
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>
@harshit-gangal
Schema RPC to fetch table/view definition (vitessio#12375)
30f8294 
* feat: proto changes to add new rpc

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* feat: vttablet changes in queryservice to implement the new rpc

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* added test on tabletserver

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* feat: use the new schema rpc in vtgate to get updated view definition

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* remove error from getschemaresponse and change the enum name

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* updated proto files for vtadmin

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* fix e2e test

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

---------

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@vitess-bot @shlomi-noach
[release-16.0] VReplication: ignore GC tables in schema analysis (vit…
cadf273 
…essio#12320) (vitessio#12362)

* TableFilter: fix excluded RE listing

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* extract GCTableNameExpression

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* VReplication: exclude GC tables when reading schema

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* wrap schema analyzis errors for better tracability

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

---------

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@frouioui
Fix SHOW VSCHEMA TABLES tests using v17 vtgate that expected dual (…
659c9c0 
…vitessio#12381)

* Fix SHOW VSCHEMA TABLES tests using v17 vtgate

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Fix tests expectations

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot @dependabot
Bump golang.org/x/net from 0.5.0 to 0.7.0 (vitessio#12400)
536bf4c 
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.5.0 to 0.7.0.
- [Release notes](https://github.com/golang/net/releases)
- [Commits](golang/net@v0.5.0...v0.7.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@frouioui @shlomi-noach @rohit-nayak-ps
Allow zero (in) date when setting up internal _vt schema (vitessio#12262
08362bc 
) (vitessio#12406)

* Allow zero (in) date when setting up internal _vt schema



* modify test sto include @@sql_mod query support



* Allow zero (in) date when setting up internal _vt schema



* modify test sto include @@sql_mod query support



* Fix test failures



* Fix failing tests. Minor refactor



* change sql_mode t omost permissive (empty)



* setPermissiveSQLMode



* fixes per review



* Add missing mock query



---------

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Co-authored-by: Rohit Nayak <rohit@planetscale.com>
@frouioui
Add release notes summary for views (vitessio#12422)
52defd6 
* Add release notes summary for support views

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* add link to the documentation

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* simplify views release notes

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@mattlord
Examples: Correct VTAdmin Discovery File Path And Add Check (vitessio…
8528903 
…#12415)

* Examples: correct VTAdmin discovery file path and add check

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Remove jq dependency

Signed-off-by: Matt Lord <mattalord@gmail.com>

* vtadmin examples scripts hardcode localhost

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Fix errant expectation

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Adjust healthy shard indicator

Signed-off-by: Matt Lord <mattalord@gmail.com>

---------

Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord
VReplication: Use MariaDB Compat JSON Functions (vitessio#12420)
fa2c0a6 
This is needed to better support importing from
MariaDB into Vitess/MySQL.

Signed-off-by: Matt Lord <mattalord@gmail.com>
@frouioui @harshit-gangal
Change GetSchema RPC to return CreateView instead of SelectStmt (…
79014d3 
…vitessio#12421)

* Changed getSchemaRPC to return CreateView instead of SelectStmt

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* test: fix expectation

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Co-authored-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal @GuptaManan100 @frouioui
Create Views allowed for same keyspace (vitessio#12409)
91fe415 
* restrict views to single keyspace

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* feat: also create/alter and drop views on MySQL for information-schema-support

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: do the DMLs for alter and create of view in a transaction so that they can be rolled back in case of MySQL failure

Signed-off-by: Manan Gupta <manan@planetscale.com>

* ignore view changes by schema tracker in vttablet when views are enabled

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* test: fix test expectation

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* Correct syntax error in defer func of E2E test

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
@shlomi-noach
Backport to v16: onlineddl_vrepl flakiness and subsequent fixes (vite…
753a691 
…ssio#12426)

* TableFilter: fix excluded RE listing

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* extract GCTableNameExpression

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* VReplication: exclude GC tables when reading schema

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* wrap schema analyzis errors for better tracability

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* resolve conflict

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* (re)Formalize SQLError in VReplication, add underlying wrap/unwrap functionality

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* update test to match new UnwrapAll() behavior

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* do not unwrap

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* Online DDL: use LastError for retrying vreplication streams

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* differentiate between a temrinally failed workflow and one which 'has error' and can be retried

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* wording

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* simplified hasError()

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* more onlineddl_vrepl tests; use dynamic throttler config; fix wait for vreplication status

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

---------

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@deepthi @frouioui @GuptaManan100
examples: Fix Vtop example and release script (vitessio#12440)
c37bdd7 
* examples: should use mysql80 property for vitess image

Signed-off-by: deepthi <deepthi@planetscale.com>

* Use MySQL80 in all examples/operator YAML files

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* feat: fix vtadmin image version

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: update release script to update vtadmin image version too

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: fix vtop example script to use vtctldclient instead

Signed-off-by: Manan Gupta <manan@planetscale.com>

---------

Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Manan Gupta <manan@planetscale.com>
@rohit-nayak-ps @shlomi-noach
Sidecar schema init: use COPY algorithm while altering sidecardb tabl…
e429768 
…es (vitessio#12436)

* schemadiff: AlterTableAlgorithmStratgy

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* minor rename

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* Use COPY algorithm while altering sidecardb tables

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

---------

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@vitess-bot @dbussink
Update additional Go dependencies (vitessio#12402)
a8e11e8 
Dependabot does pick up these go.mod files but somehow fails to open PRs
for them to update things that are vulnerable. So doing it manually
here.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>
@vitess-bot @rohit-nayak-ps
[release-16.0] SidecarDB Init: don't fail on schema init errors (vite…
57f469d 
…ssio#12328) (vitessio#12431)

* Don't fail on schema init errors

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* Fix debug var attribute name

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* Fix typo in debug var

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* Address review comment

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* Address review comments

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

---------

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Co-authored-by: Rohit Nayak <rohit@planetscale.com>
vitess-bot bot and others added 8 commits November 22, 2023 00:13
@vitess-bot @frouioui
[release-16.0] expression rewriting: enable more rewrites and limit C…
53dfd30 
…NF rewrites (vitessio#14560) (vitessio#14574)

Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot @harshit-gangal @dbussink
[release-16.0] fix concurrency on stream execute engine primitives (v…
551dbd1 
…itessio#14586) (vitessio#14590)

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Co-authored-by: Harshit Gangal <harshit@planetscale.com>
Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>
@systay
[16.0] bug fix: stop all kinds of expressions from cnf-exploding (vit…
a8b6d48 
…essio#14595)
@shlomi-noach
[release-16.0] Replace use of WAIT_UNTIL_SQL_THREAD_AFTER_GTIDS wit…
151b1b0 
…h `WAIT_FOR_EXECUTED_GTID_SET` (vitessio#14612) (vitessio#14620)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@arthurschreiber
Merge branch 'release-16.0' of https://github.com/vitessio/vitess int…
43a0748 
…o release-16.0-github

Signed-off-by: Arthur Schreiber <arthurschreiber@github.com>
@arthurschreiber
Expose the --tablet_types_to_wait flag in vtcombo.
9376417 
Signed-off-by: Arthur Schreiber <arthurschreiber@github.com>
@arthurschreiber
Merge pull request #93 from github/arthur/vtcombo-tablet-type-counts
ea0e19c 
[Backport] Expose the `--tablet_types_to_wait` flag in `vtcombo`.
@hmaurer
Backport vitessio#15275
bab4912
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Mar 21, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Mar 21, 2024
@hmaurer hmaurer closed this Mar 21, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Mar 21, 2024
@hmaurer hmaurer changed the title hm/backport vtexplain fix oops Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@ajm188 ajm188 Awaiting requested review from ajm188 ajm188 is a code owner

@notfelineit notfelineit Awaiting requested review from notfelineit notfelineit is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@arthurschreiber arthurschreiber Awaiting requested review from arthurschreiber arthurschreiber is a code owner

@vmg vmg Awaiting requested review from vmg vmg is a code owner

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@dkhenry dkhenry Awaiting requested review from dkhenry

Assignees
No one assigned
Labels
NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says
Projects
None yet
Milestone
v20.0.0
Development

Successfully merging this pull request may close these issues.