-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport to v16: onlineddl_vrepl flakiness and subsequent fixes #12426
Merged
shlomi-noach
merged 13 commits into
vitessio:release-16.0
from
planetscale:onlineddl-vrpel-flaky-tests-fixes
Feb 23, 2023
Merged
Backport to v16: onlineddl_vrepl flakiness and subsequent fixes #12426
shlomi-noach
merged 13 commits into
vitessio:release-16.0
from
planetscale:onlineddl-vrpel-flaky-tests-fixes
Feb 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
…nctionality Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
… error' and can be retried Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
…r vreplication status Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
Double and triple checked the changes (since I backported manually) -- looks good. |
frouioui
approved these changes
Feb 23, 2023
dbussink
approved these changes
Feb 23, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport
This is a backport
Component: Build/CI
Component: Online DDL
Online DDL (vitess/native/gh-ost/pt-osc)
Component: VReplication
Type: Bug
Type: CI/Build
Type: Testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This backport was crafted manually and includes these combined PRs, in this order:
vitess
ALTER TABLE
migrations #12323onlineddl_vrepl
flakiness, and adding more tests #12325(noteworthy that related #12318 and #12320 have already been backported, automatically)
The fixes include:
LastError
as a public structSqlError
invreplication
vreplication
errors more gracefully, and retries/waits where possibleendtoend
tests, optimizeendtoend
tests with new throttler config, fix wasteful wait for vreplication statusRelated Issue(s)
vitess
migrations) #12322Checklist
Deployment Notes