Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change GetSchema RPC to return CreateView instead of SelectStmt #12421

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Change GetSchema RPC to return CreateView instead of SelectStmt #12421

merged 2 commits into from
Feb 23, 2023

Conversation

frouioui
Copy link
Member

Description

This PR changes GetSchema RPC to return CreateView instead of SelectStmt.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@frouioui
Changed getSchemaRPC to return CreateView instead of SelectStmt
9e5a6ad 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving labels Feb 22, 2023
@frouioui frouioui added the Forwardport to: main This will forward port the PR to the main branch label Feb 22, 2023
@frouioui frouioui changed the title Changed GetSchema RPC to return CreateView instead of SelectStmt Change GetSchema RPC to return CreateView instead of SelectStmt Feb 22, 2023
@harshit-gangal
test: fix expectation
effc843 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
GuptaManan100
GuptaManan100 approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the changes, but just want to confirm why are we dropping the ViewStatement field. Is it just because we don't need it and is like a duplicated thing already part of the create view statement?

@harshit-gangal
Copy link
Member

I understand the changes, but just want to confirm why are we dropping the ViewStatement field. Is it just because we don't need it and is like a duplicated thing already part of the create view statement?

Yes, create view has more information than the select statement part of it. If we need additional information about the view, it is present in create view statement that can be used.

@harshit-gangal harshit-gangal merged commit 79014d3 into vitessio:release-16.0 Feb 23, 2023
@harshit-gangal harshit-gangal deleted the views-hg-fp branch February 23, 2023 02:33
@vitess-bot vitess-bot bot mentioned this pull request Feb 23, 2023
Merged
harshit-gangal added a commit that referenced this pull request Feb 23, 2023
@vitess-bot @frouioui @harshit-gangal
[main] Change GetSchema RPC to return CreateView instead of `Sele…
a3e51ad 
…ctStmt` (#12421) (#12441)

* Changed getSchemaRPC to return CreateView instead of SelectStmt

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* test: fix expectation

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Harshit Gangal <harshit@planetscale.com>
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@systay systay Awaiting requested review from systay systay is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Forwardport to: main This will forward port the PR to the main branch Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frouioui @harshit-gangal @GuptaManan100