Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vtctldclient command in vtop test script and the fix operator example #12458

Merged
merged 4 commits into from
Feb 24, 2023
Merged

Fix vtctldclient command in vtop test script and the fix operator example #12458

merged 4 commits into from
Feb 24, 2023

Conversation

GuptaManan100
Copy link
Member

@GuptaManan100 GuptaManan100 commented Feb 23, 2023 •
edited
Loading

Description

This PR fixes a vtctldclient command which was incorrectly pushed in the PR #12440 while fixing the issue #12438

This PR also updates the operator.yaml file and removes enforceSemiSync property since it is deleted.
These changes were missed in #12440 though they were included in #12457

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@GuptaManan100
feat: fix vtctldclient command
5bde2f8 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 23, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 23, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@GuptaManan100 GuptaManan100 removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 23, 2023
deepthi and others added 3 commits February 24, 2023 11:10
@deepthi @GuptaManan100
examples: remove enforceSemiSync from operator example
42e2880 
Signed-off-by: deepthi <deepthi@planetscale.com>
@GuptaManan100
Merge remote-tracking branch 'upstream/release-16.0' into command-fix-16
c8a1f6d 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
feat: also update vitess operator version
f062e08 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 changed the title Fix vtctldclient command in vtop test script Fix vtctldclient command in vtop test script and the fix operator example Feb 24, 2023
@GuptaManan100 GuptaManan100 mentioned this pull request Feb 24, 2023
Closed
4 tasks
@GuptaManan100
Copy link
Member Author

Just as a note, the test in the script vtop_example.sh were working before these changes too, but these changes are still good to make since the operator.yaml file includes the crds which are updated.

@GuptaManan100 GuptaManan100 mentioned this pull request Feb 24, 2023
Closed
51 tasks
rsajwani
rsajwani reviewed Feb 24, 2023
View reviewed changes
examples/operator/operator.yaml
@@ -74,8 +74,35 @@ spec:
- kind
- name
type: object
x-kubernetes-map-type: atomic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for my knowledge.. Is it some auto generated file ? and what are all these changes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is auto generated, but on vitess-operator. Whenever it changes, we have to copy them here, but I forgot to do that this time. 😭
Anyways these changes came from upgrading the controller-gen version from controller-gen.kubebuilder.io/version: v0.6.2 to controller-gen.kubebuilder.io/version: v0.11.3

harshit-gangal
harshit-gangal reviewed Feb 24, 2023
View reviewed changes
test/vtop_example.sh
@@ -252,7 +252,7 @@ function verifyVtadminSetup() {
function verifyVTOrcSetup() {
# Set the primary tablet to readOnly using the vtctld and wait for VTOrc to repair
primaryTablet=$(getPrimaryTablet)
vtctldclient SetReadOnly "$primaryTablet"
vtctldclient SetWritable "$primaryTablet" false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still have SetReadWrite command as well?

Copy link
Member Author

@GuptaManan100 GuptaManan100 Feb 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we don't. In vtctldclient we only have SetWritable.
In vtctlclient we have SetReadOnly and SetReadWrite

@frouioui frouioui merged commit 492cf00 into vitessio:release-16.0 Feb 24, 2023
@frouioui frouioui deleted the command-fix-16 branch February 24, 2023 09:52
rsajwani
rsajwani reviewed Feb 24, 2023
View reviewed changes
Copy link
Contributor

@rsajwani rsajwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsajwani rsajwani rsajwani left review comments

@frouioui frouioui frouioui approved these changes

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

Assignees
No one assigned
Labels
Component: Examples Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GuptaManan100 @rsajwani @harshit-gangal @frouioui @deepthi