Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gen4 planner] Make sure to not push down expressions when not possible #12607

Merged
merged 5 commits into from
Mar 17, 2023

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Mar 10, 2023

Description

This PR fixes #12540 by making sure to not push down to MySQL complex expressions that involved aggregations.

If we have a derived table and it's aggregating results for us, we can't use these results until the are fully aggregated, which happens on the vtgate level.

select dt.a,
       dt.b,
       (dt.a / dt.b)
from (select sum(a) as a,
             sum(b) as b
      from user) dt

In the query above, since we have to spread out the aggregation across all user shards, we can't push down the division between the two sums until after summing up the individual shard results.

Related Issue(s)

Fixes #12540

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Mar 10, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Mar 10, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

Copy link
Collaborator

@systay systay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't this is correct. The query we are trying to fix should not be using the AggregateRandom expression here in the first place

…level

Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay changed the title Fix random aggregation to not select Null columns [gen4 planner] Make sure to not push down expressions when not possible Mar 15, 2023
Signed-off-by: Andres Taylor <andres@planetscale.com>
Copy link
Member Author

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@arthurschreiber arthurschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui merged commit d185e0e into vitessio:main Mar 17, 2023
@frouioui frouioui deleted the fix-12540 branch March 17, 2023 06:27
frouioui added a commit to planetscale/vitess that referenced this pull request Mar 17, 2023
…le (vitessio#12607)

* Fix random aggregation to not select Null column

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* stop pushing down projections that should be evaluated at the vtgate level

Signed-off-by: Andres Taylor <andres@planetscale.com>

* undo changes to AggregateRandom

Signed-off-by: Andres Taylor <andres@planetscale.com>

* clean up code

Signed-off-by: Andres Taylor <andres@planetscale.com>

* fix executor test mock

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>
frouioui added a commit to planetscale/vitess that referenced this pull request Mar 17, 2023
…le (vitessio#12607)

* Fix random aggregation to not select Null column

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* stop pushing down projections that should be evaluated at the vtgate level

Signed-off-by: Andres Taylor <andres@planetscale.com>

* undo changes to AggregateRandom

Signed-off-by: Andres Taylor <andres@planetscale.com>

* clean up code

Signed-off-by: Andres Taylor <andres@planetscale.com>

* fix executor test mock

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>
systay added a commit that referenced this pull request Mar 20, 2023
…le (#12607) (#12646)

* Fix random aggregation to not select Null column



* stop pushing down projections that should be evaluated at the vtgate level



* undo changes to AggregateRandom



* clean up code



* fix executor test mock



---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>
systay added a commit to planetscale/vitess that referenced this pull request Mar 20, 2023
…le (vitessio#12607)

* Fix random aggregation to not select Null column
* stop pushing down projections that should be evaluated at the vtgate level
* undo changes to AggregateRandom
* clean up code
* fix executor test mock

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
frouioui added a commit that referenced this pull request Mar 21, 2023
…le (#12607) (#12647)

* [gen4 planner] Make sure to not push down expressions when not possible (#12607)

* Fix random aggregation to not select Null column
* stop pushing down projections that should be evaluated at the vtgate level
* undo changes to AggregateRandom
* clean up code
* fix executor test mock

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>

* Fix schema error

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>
systay added a commit that referenced this pull request Mar 21, 2023
…le (#12607) (#12648)

* Fix random aggregation to not select Null column



* stop pushing down projections that should be evaluated at the vtgate level



* undo changes to AggregateRandom



* clean up code



* fix executor test mock



---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: query result based on cross shard aggregation is bad
4 participants