Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically add milestone to new Pull Request #12759

Merged
merged 4 commits into from
Apr 3, 2023
Merged

Automatically add milestone to new Pull Request #12759

merged 4 commits into from
Apr 3, 2023

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Mar 29, 2023 •
edited
Loading

Description

This Pull Request adds a tool that tells which is the current development (or production) version of Vitess. This will be used by the vitess-bot to assign milestones to Pull Request automatically.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@frouioui
Automatically add milestone to new Pull Request
3e51abc 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Mar 29, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Mar 29, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@frouioui frouioui added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: General Changes throughout the code base Backport to: release-14.0 and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Mar 29, 2023
@frouioui
Run the workflow on pull_request_target event
5894c20 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui added the Backport This is a backport label Mar 29, 2023
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Mar 29, 2023
@frouioui frouioui added Breaking change Backport This is a backport and removed Breaking change Backport This is a backport NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Mar 29, 2023
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Mar 29, 2023
@frouioui frouioui removed the Backport This is a backport label Mar 29, 2023
@frouioui frouioui removed this from the v17.0.0 milestone Mar 29, 2023
@frouioui frouioui force-pushed the assign-milestone branch 4 times, most recently from 39aa527 to abd07df Compare March 30, 2023 11:51
@frouioui
Use gh pr edit to add milestone
327a209 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Use bash instead of go script
46b4083 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Mar 31, 2023
@frouioui frouioui requested a review from mattlord March 31, 2023 11:35
@frouioui frouioui merged commit bdf59b8 into vitessio:main Apr 3, 2023
@frouioui frouioui deleted the assign-milestone branch April 3, 2023 05:33
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Apr 3, 2023

I was unable to backport this Pull Request to the following branches: release-14.0, release-15.0, release-16.0.

frouioui added a commit to planetscale/vitess that referenced this pull request Apr 3, 2023
@frouioui
Automatically add milestone to new Pull Request (vitessio#12759)
287c6ef 
* Automatically add milestone to new Pull Request

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Run the workflow on pull_request_target event

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Use gh pr edit to add milestone

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Use bash instead of go script

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui added a commit to planetscale/vitess that referenced this pull request Apr 3, 2023
@frouioui
Automatically add milestone to new Pull Request (vitessio#12759)
f2a0d88 
* Automatically add milestone to new Pull Request

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Run the workflow on pull_request_target event

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Use gh pr edit to add milestone

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Use bash instead of go script

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui added a commit to planetscale/vitess that referenced this pull request Apr 3, 2023
@frouioui
Automatically add milestone to new Pull Request (vitessio#12759)
9c41fbb 
* Automatically add milestone to new Pull Request

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Run the workflow on pull_request_target event

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Use gh pr edit to add milestone

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Use bash instead of go script

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
This was referenced Apr 3, 2023
Merged
Merged
Merged
frouioui added a commit that referenced this pull request Apr 3, 2023
@frouioui
Automatically add milestone to new Pull Request (#12759) (#12805)
fb4ed57 
* Automatically add milestone to new Pull Request



* Run the workflow on pull_request_target event



* Use gh pr edit to add milestone



* Use bash instead of go script



---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui added a commit that referenced this pull request Apr 3, 2023
@frouioui
Automatically add milestone to new Pull Request (#12759) (#12806)
fd265ea 
* Automatically add milestone to new Pull Request



* Run the workflow on pull_request_target event



* Use gh pr edit to add milestone



* Use bash instead of go script



---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui added a commit that referenced this pull request Apr 3, 2023
@frouioui
Automatically add milestone to new Pull Request (#12759) (#12807)
5ee1e46 
* Automatically add milestone to new Pull Request



* Run the workflow on pull_request_target event



* Use gh pr edit to add milestone



* Use bash instead of go script



---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattlord mattlord mattlord approved these changes

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@systay systay Awaiting requested review from systay

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

Assignees
No one assigned
Labels
Component: General Changes throughout the code base Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frouioui @rohit-nayak-ps @mattlord @GuptaManan100