Commits on Mar 30, 2023

1. Throttler: Expose Tablet's Config & Leverage to Deflake Tests (vitess… …

   …io#12737)
   
   * Flakes: effectively disable vtorc for deterministic behavior
   
   For example, we stop replication, wait a few seconds, then expect
   there to be lag. But vtorc could repair replication during that
   wait and then the lag is gone.
   
   Signed-off-by: Matt Lord <mattalord@gmail.com>
   
   * Wait for the throttler to be up and running everywhere
   
   Signed-off-by: Matt Lord <mattalord@gmail.com>
   
   * Expose tablet's throttler config and leverage to deflake tests
   
   Signed-off-by: Matt Lord <mattalord@gmail.com>
   
   * Apply various corrections
   
   Signed-off-by: Matt Lord <mattalord@gmail.com>
   
   * Be more explicit about VTOrc behavior changes
   
   Signed-off-by: Matt Lord <mattalord@gmail.com>
   
   * Note received throttler response when it is unexpected
   
   Signed-off-by: Matt Lord <mattalord@gmail.com>
   
   * Fixes from local testing
   
   Signed-off-by: Matt Lord <mattalord@gmail.com>
   
   * Nits from self review
   
   Signed-off-by: Matt Lord <mattalord@gmail.com>
   
   * Use assert.Equalf on failed assertions
   
   Signed-off-by: Matt Lord <mattalord@gmail.com>
   
   * Ummm, duh.
   
   Signed-off-by: Matt Lord <mattalord@gmail.com>
   
   * Try to get rid of last bit of flakiness
   
   Which seemed to revolve around NOT sleeping long enough
   after starting all the sleep queries.
   
   Signed-off-by: Matt Lord <mattalord@gmail.com>
   
   * Nits from self review
   
   Signed-off-by: Matt Lord <mattalord@gmail.com>
   
   * Address review comments
   
   Signed-off-by: Matt Lord <mattalord@gmail.com>
   
   * Adjust test for behavior and comment it
   
   And adjust timing
   
   Signed-off-by: Matt Lord <mattalord@gmail.com>
   
   * Align both stale hearbeat checks
   
   Signed-off-by: Matt Lord <mattalord@gmail.com>
   
   * Remove no longer needed flag
   
   This is because enabling heartbeats with --heartbeat_enable
   also results in the replication reporter being enabled:
   https://github.com/vitessio/vitess/blob/3d9ef871e42bd20a60ec95997c97ecf0694c1e78/go/vt/vttablet/tabletserver/tabletenv/config.go#L235-L237
   
   Signed-off-by: Matt Lord <mattalord@gmail.com>
   
   * Correct comment
   
   Signed-off-by: Matt Lord <mattalord@gmail.com>
   
   * Correct comment part II: electric boogaloo
   
   Signed-off-by: Matt Lord <mattalord@gmail.com>
   
   * Revert one other minor unnecessary change.
   
   Signed-off-by: Matt Lord <mattalord@gmail.com>
   
   ---------
   
   Signed-off-by: Matt Lord <mattalord@gmail.com>

   

   mattlord committed Mar 30, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 242bdf6
   • Browse repository at this point

   Copy the full SHA

   242bdf6 View commit details

   Browse the repository at this point in the history

2. Post cherry-pick fixup …

   Signed-off-by: Matt Lord <mattalord@gmail.com>

   

   mattlord committed Mar 30, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 0c59ef8
   • Browse repository at this point

   Copy the full SHA

   0c59ef8 View commit details

   Browse the repository at this point in the history