Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-16.0] Throttler: Expose Tablet's Config & Leverage to Deflake Tests #12791

Merged
merged 2 commits into from
Mar 31, 2023
Merged

[release-16.0] Throttler: Expose Tablet's Config & Leverage to Deflake Tests #12791

merged 2 commits into from
Mar 31, 2023

Conversation

mattlord
Copy link
Contributor

@mattlord mattlord commented Mar 30, 2023 •
edited by rohit-nayak-ps
Loading

Description

This is a backport of #12737.

@mattlord
Throttler: Expose Tablet's Config & Leverage to Deflake Tests (vitess…
242bdf6 
…io#12737)

* Flakes: effectively disable vtorc for deterministic behavior

For example, we stop replication, wait a few seconds, then expect
there to be lag. But vtorc could repair replication during that
wait and then the lag is gone.

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Wait for the throttler to be up and running everywhere

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Expose tablet's throttler config and leverage to deflake tests

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Apply various corrections

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Be more explicit about VTOrc behavior changes

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Note received throttler response when it is unexpected

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Fixes from local testing

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Nits from self review

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Use assert.Equalf on failed assertions

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Ummm, duh.

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Try to get rid of last bit of flakiness

Which seemed to revolve around NOT sleeping long enough
after starting all the sleep queries.

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Nits from self review

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Address review comments

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Adjust test for behavior and comment it

And adjust timing

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Align both stale hearbeat checks

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Remove no longer needed flag

This is because enabling heartbeats with --heartbeat_enable
also results in the replication reporter being enabled:
https://github.com/vitessio/vitess/blob/3d9ef871e42bd20a60ec95997c97ecf0694c1e78/go/vt/vttablet/tabletserver/tabletenv/config.go#L235-L237

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Correct comment

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Correct comment part II: electric boogaloo

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Revert one other minor unnecessary change.

Signed-off-by: Matt Lord <mattalord@gmail.com>

---------

Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Build/CI Type: Testing Backport This is a backport Flakes labels Mar 30, 2023
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Mar 30, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Mar 30, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@mattlord
Post cherry-pick fixup
0c59ef8 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord added Breaking change and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says Breaking change labels Mar 30, 2023
rohit-nayak-ps
rohit-nayak-ps approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rohit-nayak-ps rohit-nayak-ps merged commit f2c1c13 into vitessio:release-16.0 Mar 31, 2023
@rohit-nayak-ps rohit-nayak-ps deleted the backport-12737-to-release-16.0 branch March 31, 2023 18:06
This was referenced Jun 29, 2023
Closed
Merged
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbussink dbussink dbussink approved these changes

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

Assignees
No one assigned
Labels
Backport This is a backport Component: Build/CI Flakes Type: Enhancement Logical improvement (somewhere between a bug and feature) Type: Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattlord @dbussink @rohit-nayak-ps