Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[planbuilder bugfix] do not push aggregations into derived tables #12810

Merged
merged 2 commits into from
Apr 4, 2023
Merged

[planbuilder bugfix] do not push aggregations into derived tables #12810

merged 2 commits into from
Apr 4, 2023

Conversation

systay
Copy link
Collaborator

@systay systay commented Apr 3, 2023 •
edited
Loading

Description

We can't push predicates with aggregations into derived tables - we need to evaluate the derived table and only after can we evaluate the predicate.

Related Issue(s)

Fixes #12798

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

@systay
fixes vitessio#12798
22dc0e1 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Apr 3, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Apr 3, 2023 •
edited by frouioui
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@systay systay removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Apr 3, 2023
@systay
[planbuilder bugfix] don't push down predicates that need to be aggre…
44b2135 
…gated at the vtgate level

Signed-off-by: Andres Taylor <andres@planetscale.com>
@github-actions github-actions bot added this to the v17.0.0 milestone Apr 3, 2023
@frouioui frouioui merged commit 4d0a974 into vitessio:main Apr 4, 2023
@frouioui frouioui deleted the fix-12798 branch April 4, 2023 09:37
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Apr 4, 2023

I was unable to backport this Pull Request to the following branches: release-14.0, release-15.0, release-16.0.

frouioui pushed a commit to planetscale/vitess that referenced this pull request Apr 4, 2023
@systay @frouioui
[planbuilder bugfix] do not push aggregations into derived tables (vi…
7095669 
…tessio#12810)

* fixes vitessio#12798

Signed-off-by: Andres Taylor <andres@planetscale.com>

* [planbuilder bugfix] don't push down predicates that need to be aggregated at the vtgate level

Signed-off-by: Andres Taylor <andres@planetscale.com>

---------

Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui mentioned this pull request Apr 4, 2023
Merged
frouioui pushed a commit to planetscale/vitess that referenced this pull request Apr 4, 2023
@systay @frouioui
[planbuilder bugfix] do not push aggregations into derived tables (vi…
2037969 
…tessio#12810)

* fixes vitessio#12798

Signed-off-by: Andres Taylor <andres@planetscale.com>

* [planbuilder bugfix] don't push down predicates that need to be aggregated at the vtgate level

Signed-off-by: Andres Taylor <andres@planetscale.com>

---------

Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui pushed a commit to planetscale/vitess that referenced this pull request Apr 4, 2023
@systay @frouioui
[planbuilder bugfix] do not push aggregations into derived tables (vi…
06072a6 
…tessio#12810)

* fixes vitessio#12798

Signed-off-by: Andres Taylor <andres@planetscale.com>

* [planbuilder bugfix] don't push down predicates that need to be aggregated at the vtgate level

Signed-off-by: Andres Taylor <andres@planetscale.com>

---------

Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
This was referenced Apr 4, 2023
Merged
Merged
systay added a commit that referenced this pull request Apr 4, 2023
@frouioui @systay
[planbuilder bugfix] do not push aggregations into derived tables (#1…
f4c19c9 
…2810) (#12825)

* fixes #12798



* [planbuilder bugfix] don't push down predicates that need to be aggregated at the vtgate level



---------

Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Andres Taylor <andres@planetscale.com>
frouioui added a commit that referenced this pull request Apr 5, 2023
@frouioui @systay
[planbuilder bugfix] do not push aggregations into derived tables (#1…
0b85e17 
…2810) (#12824)

* fixes #12798



* [planbuilder bugfix] don't push down predicates that need to be aggregated at the vtgate level



---------

Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Andres Taylor <andres@planetscale.com>
harshit-gangal pushed a commit that referenced this pull request Apr 11, 2023
@frouioui @systay
[planbuilder bugfix] do not push aggregations into derived tables (#1…
ee547c8 
…2810) (#12823)

* fixes #12798



* [planbuilder bugfix] don't push down predicates that need to be aggregated at the vtgate level



---------

Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Andres Taylor <andres@planetscale.com>
frouioui pushed a commit to planetscale/vitess that referenced this pull request Nov 21, 2023
@planetscale-actions-bot @rohit-nayak-ps
CherryPick(vitessio#12810): [planbuilder bugfix] do not push aggregat…
cfdecd7 
…ions into derived tables (vitessio#1812)

* cherry pick of 12810

Signed-off-by: Vitess Cherry-Pick Bot <vitess-cherrypick-bot@planetscale.com>

* Fix conflict

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

---------

Signed-off-by: Vitess Cherry-Pick Bot <vitess-cherrypick-bot@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Co-authored-by: Vitess Cherry-Pick Bot <vitess-cherrypick-bot@planetscale.com>
Co-authored-by: Rohit Nayak <rohit@planetscale.com>
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@arthurschreiber arthurschreiber Awaiting requested review from arthurschreiber arthurschreiber is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Bug
Projects
None yet
Milestone
v17.0.0
Development

Successfully merging this pull request may close these issues.

Bug Report: v14 rewriting query with group by and results in syntax error
3 participants
@systay @frouioui @GuptaManan100