-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fixes to the auto-upgrade golang tool #12838
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui
requested review from
systay,
deepthi,
mattlord and
rohit-nayak-ps
as code owners
April 5, 2023 14:56
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
labels
Apr 5, 2023
frouioui
added
Type: Bug
Component: Build/CI
go
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
labels
Apr 5, 2023
dbussink
approved these changes
Apr 5, 2023
GuptaManan100
approved these changes
Apr 6, 2023
rohit-nayak-ps
pushed a commit
that referenced
this pull request
Apr 10, 2023
…12848) * fix float issue with bootstrap version increment Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * handle case where there are no minor bootstrap version Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * avoid re-creating Pull Requests Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * remove parse float Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
deepthi
pushed a commit
that referenced
this pull request
Apr 11, 2023
…12847) * fix float issue with bootstrap version increment Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * handle case where there are no minor bootstrap version Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * avoid re-creating Pull Requests Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * remove parse float Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui
added a commit
that referenced
this pull request
Apr 12, 2023
…12846) * fix float issue with bootstrap version increment Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * handle case where there are no minor bootstrap version Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * avoid re-creating Pull Requests Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * remove parse float Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui
added a commit
to planetscale/vitess
that referenced
this pull request
Nov 21, 2023
…o#1837) * fix float issue with bootstrap version increment * handle case where there are no minor bootstrap version * avoid re-creating Pull Requests --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We could see two issues in the previous golang upgrade auto Pull Requests:
14.2999999..
instead of14.3
. This is because the summing operations of two float can give different results if there are some gaps in the mantissa.These two issues are now fixed in this PR.
Checklist
Deployment Notes