Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes to the auto-upgrade golang tool #12838

Merged
merged 3 commits into from
Apr 6, 2023

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Apr 5, 2023

Description

We could see two issues in the previous golang upgrade auto Pull Requests:

  • The bootstrap version was 14.2999999.. instead of 14.3. This is because the summing operations of two float can give different results if there are some gaps in the mantissa.
  • The bot would re-create the Pull Request on top of the already existing one.

These two issues are now fixed in this PR.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Apr 5, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Apr 5, 2023
@frouioui frouioui added Type: Bug Component: Build/CI go and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Apr 5, 2023
@github-actions github-actions bot added this to the v17.0.0 milestone Apr 5, 2023
go/tools/go-upgrade/go-upgrade.go Show resolved Hide resolved
@frouioui frouioui merged commit 23246ff into vitessio:main Apr 6, 2023
@frouioui frouioui deleted the fix-go-upgrade-tool branch April 6, 2023 07:51
rohit-nayak-ps pushed a commit that referenced this pull request Apr 10, 2023
…12848)

* fix float issue with bootstrap version increment

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* handle case where there are no minor bootstrap version

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* avoid re-creating Pull Requests

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* remove parse float

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
deepthi pushed a commit that referenced this pull request Apr 11, 2023
…12847)

* fix float issue with bootstrap version increment

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* handle case where there are no minor bootstrap version

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* avoid re-creating Pull Requests

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* remove parse float

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui added a commit that referenced this pull request Apr 12, 2023
…12846)

* fix float issue with bootstrap version increment

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* handle case where there are no minor bootstrap version

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* avoid re-creating Pull Requests

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* remove parse float

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui added a commit to planetscale/vitess that referenced this pull request Nov 21, 2023
…o#1837)

* fix float issue with bootstrap version increment



* handle case where there are no minor bootstrap version



* avoid re-creating Pull Requests



---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants